Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 18690003: Abort SandboxedUnpacker::RewriteImageFiles on browser shutdown (Closed)

Created:
7 years, 5 months ago by Dmitry Polukhin
Modified:
7 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Abort SandboxedUnpacker::RewriteImageFiles on browser shutdown Add ability to check if shutdown was initiated for threading pool. BUG=235525 TEST=run existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210917

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M base/threading/sequenced_worker_pool.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dmitry Polukhin
brettw@ for OWNER review in base/
7 years, 5 months ago (2013-07-04 14:50:47 UTC) #1
asargent_no_longer_on_chrome
LGTM
7 years, 5 months ago (2013-07-08 21:19:58 UTC) #2
Dmitry Polukhin
Brett, please take a look to base/* changes, I need OWNER review there.
7 years, 5 months ago (2013-07-09 09:34:40 UTC) #3
Dmitry Polukhin
+ jar@ for OWNER review in base/threading/sequenced_worker_pool.*
7 years, 5 months ago (2013-07-10 13:38:26 UTC) #4
jar (doing other things)
base changes LGTM %nit https://codereview.chromium.org/18690003/diff/1/base/threading/sequenced_worker_pool.h File base/threading/sequenced_worker_pool.h (right): https://codereview.chromium.org/18690003/diff/1/base/threading/sequenced_worker_pool.h#newcode320 base/threading/sequenced_worker_pool.h:320: // for aborting time consuming ...
7 years, 5 months ago (2013-07-10 15:07:05 UTC) #5
Dmitry Polukhin
https://codereview.chromium.org/18690003/diff/1/base/threading/sequenced_worker_pool.h File base/threading/sequenced_worker_pool.h (right): https://codereview.chromium.org/18690003/diff/1/base/threading/sequenced_worker_pool.h#newcode320 base/threading/sequenced_worker_pool.h:320: // for aborting time consuming operation to don't block ...
7 years, 5 months ago (2013-07-10 17:24:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/18690003/24001
7 years, 5 months ago (2013-07-10 17:25:23 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 20:19:26 UTC) #8
Message was sent while issue was closed.
Change committed as 210917

Powered by Google App Engine
This is Rietveld 408576698