Issue 18686006: [cros] Cleanup login auth stack: remove ClientLogin legacy code

Issue 18686006: [cros] Cleanup login auth stack: remove ClientLogin legacy code (Closed)

Created:
7 years, 5 months ago by Nikita (slow)

Modified:
7 years, 5 months ago

Reviewers:
Denis Kuznetsov (DE-MUC)

CC:
chromium-reviews, oshima+watch_chromium.og, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, xiyuan, zel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] Cleanup login auth stack: remove ClientLogin legacy code * Remove Autheticator::RetryAuth() - was used to retry ClientLogin * Remove Authenticator::AuthenticateToLogin() login_token, login_captcha parameters * LoginPerformer - remove all code related to bringing up ScreenLock and dealing with ClientLogin results * ParallelAuthenticator - make NEED_NEW_PW, HAVE_NEW_PW and ONLINE_FAILED states obsolete (ClientLogin related). * ParallelAuthenticator unit_test - remove related test cases, always use OAuth code path BUG=106538, 157246, 260219 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211779

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -715 lines)			Patch
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/authenticator.h	View	1	2 chunks	+1 line, -10 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_performer.h	View		5 chunks	+1 line, -78 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_performer.cc	View	1 2	9 chunks	+23 lines, -247 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_authenticator.h	View	1	2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_authenticator.cc	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/parallel_authenticator.h	View	1 2 3	7 chunks	+54 lines, -79 lines	0 comments	Download
M	chrome/browser/chromeos/login/parallel_authenticator.cc	View	1 2	11 chunks	+8 lines, -147 lines	0 comments	Download
M	chrome/browser/chromeos/login/parallel_authenticator_unittest.cc	View	1	5 chunks	+2 lines, -138 lines	0 comments	Download