Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 18684002: Fixing destruction order in login database unit tests (Closed)

Created:
7 years, 5 months ago by mpawlowski
Modified:
7 years, 5 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fixing destruction order in login database unit tests Before, the ScopedTempDir would be destroyed before LoginDatabase, which would still be locking the database file within the temporary folder. This would cause an error in ScopedTempDir's d-tor, and the temporary folder would stay on disk. Now the order of LoginDatabaseTest's members is aligned to the order of initialization in SetUp and LoginDatabase is destroyed before ScopedTempDir. This also makes the tests run a lot faster on my Windows machine (>4s to 110ms). TEST=unit_tests.exe --gtest_filter="LoginDatabaseTest.*" BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/password_manager/login_database_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mpawlowski
7 years, 5 months ago (2013-07-04 09:09:33 UTC) #1
stuartmorgan
lgtm
7 years, 5 months ago (2013-07-08 07:32:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpawlowski@opera.com/18684002/1
7 years, 5 months ago (2013-07-08 07:37:30 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-08 07:42:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpawlowski@opera.com/18684002/1
7 years, 5 months ago (2013-07-08 07:54:48 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-08 13:36:25 UTC) #6
Message was sent while issue was closed.
Change committed as 210374

Powered by Google App Engine
This is Rietveld 408576698