Fixing destruction order in login database unit tests

Fixing destruction order in login database unit tests

Before, the ScopedTempDir would be destroyed before
LoginDatabase, which would still be locking the database file
within the temporary folder. This would cause an error in
ScopedTempDir's d-tor, and the temporary folder would stay
on disk.

Now the order of LoginDatabaseTest's members is aligned to
the order of initialization in SetUp and LoginDatabase is
destroyed before ScopedTempDir. This also makes the tests
run a lot faster on my Windows machine (>4s to 110ms).

TEST=unit_tests.exe --gtest_filter="LoginDatabaseTest.*"
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210374

[stuartmorgan, 2013-07-08 07:32:05]

lgtm

[commit-bot: I haz the power, 2013-07-08 07:37:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpawlowski@opera.com/18684002/1

[commit-bot: I haz the power, 2013-07-08 07:42:55]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-07-08 07:54:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpawlowski@opera.com/18684002/1

[commit-bot: I haz the power, 2013-07-08 13:36:25]

Change committed as 210374