Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 18674005: Fix a crash when built with 10.7 SDK running on OS X 10.6 (Closed)

Created:
7 years, 5 months ago by Jiang Jiang
Modified:
7 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix a crash when built with 10.7 SDK running on OS X 10.6 NSWindowDidChangeBackingPropertiesNotification is available since 10.7. Our buildbots use OS X 10.7 SDK to build with minimum target system version set to 10.6. For features available only to 10.7 and up, we normally have runtime guard to check if the system is 10.6 then we don't use it. However this one is in chromium content module and it doesn't have such runtime check. We don't know the exact details of chromium buildbot or how do they make release builds, it seems that they are building 10.6 releases with 10.6 SDK (which will disable the feature in compile time). BUG=260595 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212060

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jiang Jiang
Hi, it might be a Opera specific issue (since we built 10.6 builds with 10.7 ...
7 years, 5 months ago (2013-07-11 10:27:02 UTC) #1
Nico
Hi Jiang, our bots build with the 10.6 SDK, which is probably why we don't ...
7 years, 5 months ago (2013-07-11 22:13:33 UTC) #2
Jiang Jiang
On 2013/07/11 22:13:33, Nico wrote: > Hi Jiang, > > our bots build with the ...
7 years, 5 months ago (2013-07-12 08:39:01 UTC) #3
Nico
On 2013/07/12 08:39:01, Jiang wrote: > On 2013/07/11 22:13:33, Nico wrote: > > Hi Jiang, ...
7 years, 5 months ago (2013-07-15 17:10:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/18674005/6001
7 years, 5 months ago (2013-07-17 08:26:44 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 16:35:33 UTC) #6
Message was sent while issue was closed.
Change committed as 212060

Powered by Google App Engine
This is Rietveld 408576698