Support creating progress bar notification for Windows

Support creating progress bar notification for Windows

This is the 1st patch to add progress bar notification support. It contains:
1) A new progress type is added and a new optional progress value is added.
2) NotificationView creates and adds a NotificationProgressbar child view.

BUG=170924
TEST=manual test by creating a progress bar notification

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213287

[jianli, 2013-07-12 17:44:59]

dewittj, could you please review all rich notification changes?

sky, could you please review the change to ui/views/controls/progress_bar.cc?
I've made ProgressBar to support insets.

[dewittj, 2013-07-12 17:50:24]

Can you please add some tests around the API, in particular about progress is
valid iff it's type progress?

I don't see any bounds-checking of the progress parameter.  Can we add it and a
test for that as well?

[jianli, 2013-07-12 19:19:32]

On 2013/07/12 17:50:24, dewittj wrote:
> Can you please add some tests around the API, in particular about progress is
> valid iff it's type progress?
> 
> I don't see any bounds-checking of the progress parameter.  Can we add it and
a
> test for that as well?

Done.

[dewittj, 2013-07-15 15:32:15]

lgtm + comment

https://codereview.chromium.org/18662006/diff/36001/ui/message_center/views/n...
File ui/message_center/views/notification_view.cc (right):

https://codereview.chromium.org/18662006/diff/36001/ui/message_center/views/n...
ui/message_center/views/notification_view.cc:466:
progress_bar_view_->set_border(MakeProgressBarBorder(12, 2));
What are these constants?  Can we name them?

[sky, 2013-07-15 19:52:41]

https://codereview.chromium.org/18662006/diff/36001/ui/views/controls/progres...
File ui/views/controls/progress_bar.cc (right):

https://codereview.chromium.org/18662006/diff/36001/ui/views/controls/progres...
ui/views/controls/progress_bar.cc:198: int bar_left = insets.left();
GetContentBounds() takes care of insets for you.

[jianli, 2013-07-23 19:04:53]

https://codereview.chromium.org/18662006/diff/36001/ui/message_center/views/n...
File ui/message_center/views/notification_view.cc (right):

https://codereview.chromium.org/18662006/diff/36001/ui/message_center/views/n...
ui/message_center/views/notification_view.cc:466:
progress_bar_view_->set_border(MakeProgressBarBorder(12, 2));
On 2013/07/15 15:32:15, dewittj wrote:
> What are these constants?  Can we name them?

Done.

https://codereview.chromium.org/18662006/diff/36001/ui/views/controls/progres...
File ui/views/controls/progress_bar.cc (right):

https://codereview.chromium.org/18662006/diff/36001/ui/views/controls/progres...
ui/views/controls/progress_bar.cc:198: int bar_left = insets.left();
On 2013/07/15 19:52:41, sky wrote:
> GetContentBounds() takes care of insets for you.

Done.

[sky, 2013-07-23 21:34:25]

views LGTM

[commit-bot: I haz the power, 2013-07-23 21:47:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jianli@chromium.org/18662006/45001

[commit-bot: I haz the power, 2013-07-24 00:15:19]

Change committed as 213287