Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issue 18659002: Remove use of TestBrowserThreadBundle from unit tests in c/b/google_apis. (Closed)

Created:
7 years, 5 months ago by kinaba
Modified:
7 years, 5 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Remove use of TestBrowserThreadBundle from unit tests in c/b/google_apis. This is for removing the dependency to content/ from c/b/google_apis/ and moving the directory content to top level google_apis/. BUG=256109 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -28 lines) Patch
M chrome/browser/google_apis/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/base_requests_server_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/google_apis/base_requests_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
7 years, 5 months ago (2013-07-04 02:38:51 UTC) #1
hashimoto
lgtm, nice!
7 years, 5 months ago (2013-07-04 03:15:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/18659002/1
7 years, 5 months ago (2013-07-04 03:17:05 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-04 06:26:10 UTC) #4
Message was sent while issue was closed.
Change committed as 210141

Powered by Google App Engine
This is Rietveld 408576698