Added a high-color (50 colors) gradient for each gradient type.

Added a high-color (50 colors) gradient for each gradient type.

To do so I added an enumerated type called ColorType that can toggle between kColors_2 and kColors_50 to swap between 2 and 50 color gradients.





Added hicolor bench for each gradient type.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=9960

[bsalomon, 2013-07-09 21:29:45]

https://codereview.chromium.org/18655012/diff/2001/bench/GradientBench.cpp
File bench/GradientBench.cpp (right):

https://codereview.chromium.org/18655012/diff/2001/bench/GradientBench.cpp#ne...
bench/GradientBench.cpp:293: DEF_BENCH( return new GradientBench(p,
kSweep_GradType, kColors_50); )
Maybe just pass the GradData instance that you want to use directly and skip the
enum?

[dierk, 2013-07-10 15:01:26]

https://codereview.chromium.org/18655012/diff/2001/bench/GradientBench.cpp
File bench/GradientBench.cpp (right):

https://codereview.chromium.org/18655012/diff/2001/bench/GradientBench.cpp#ne...
bench/GradientBench.cpp:293: DEF_BENCH( return new GradientBench(p,
kSweep_GradType, kColors_50); )
I used enums to match the style of the existing code. If I passed the GradData
directly instead what would be the best way of appending something (in this case
"_hicolor") to the name string to distinguish the new tests (in a readable
fashion)? 

On 2013/07/09 21:29:45, bsalomon wrote:
> Maybe just pass the GradData instance that you want to use directly and skip
the
> enum?

[bsalomon, 2013-07-10 15:21:21]

https://codereview.chromium.org/18655012/diff/2001/bench/GradientBench.cpp
File bench/GradientBench.cpp (right):

https://codereview.chromium.org/18655012/diff/2001/bench/GradientBench.cpp#ne...
bench/GradientBench.cpp:293: DEF_BENCH( return new GradientBench(p,
kSweep_GradType, kColors_50); )
You could have:

struct GradData {
    int             fCount;
    const SkColor*  fColors;
    const SkScalar* fPos;
    const char*     fName;
}

and set fName to "" and "hicolor".

I don't feel very strongly about this but it seems a little easier to understand
to me.


On 2013/07/10 15:01:26, dierk wrote:
> I used enums to match the style of the existing code. If I passed the GradData
> directly instead what would be the best way of appending something (in this
case
> "_hicolor") to the name string to distinguish the new tests (in a readable
> fashion)? 
> 
> On 2013/07/09 21:29:45, bsalomon wrote:
> > Maybe just pass the GradData instance that you want to use directly and skip
> the
> > enum?
>

[dierk, 2013-07-10 15:41:12]

https://codereview.chromium.org/18655012/diff/2001/bench/GradientBench.cpp
File bench/GradientBench.cpp (right):

https://codereview.chromium.org/18655012/diff/2001/bench/GradientBench.cpp#ne...
bench/GradientBench.cpp:293: DEF_BENCH( return new GradientBench(p,
kSweep_GradType, kColors_50); )
On 2013/07/10 15:21:21, bsalomon wrote:
> You could have:
> 
> struct GradData {
>     int             fCount;
>     const SkColor*  fColors;
>     const SkScalar* fPos;
>     const char*     fName;
> }
> 
> and set fName to "" and "hicolor".
> 
> I don't feel very strongly about this but it seems a little easier to
understand
> to me.
> 
> 
> On 2013/07/10 15:01:26, dierk wrote:
> > I used enums to match the style of the existing code. If I passed the
GradData
> > directly instead what would be the best way of appending something (in this
> case
> > "_hicolor") to the name string to distinguish the new tests (in a readable
> > fashion)? 
> > 
> > On 2013/07/09 21:29:45, bsalomon wrote:
> > > Maybe just pass the GradData instance that you want to use directly and
skip
> > the
> > > enum?
> > 
> 

Done.

[bsalomon, 2013-07-10 15:43:33]

On 2013/07/10 15:41:12, dierk wrote:
> https://codereview.chromium.org/18655012/diff/2001/bench/GradientBench.cpp
> File bench/GradientBench.cpp (right):
> 
>
https://codereview.chromium.org/18655012/diff/2001/bench/GradientBench.cpp#ne...
> bench/GradientBench.cpp:293: DEF_BENCH( return new GradientBench(p,
> kSweep_GradType, kColors_50); )
> On 2013/07/10 15:21:21, bsalomon wrote:
> > You could have:
> > 
> > struct GradData {
> >     int             fCount;
> >     const SkColor*  fColors;
> >     const SkScalar* fPos;
> >     const char*     fName;
> > }
> > 
> > and set fName to "" and "hicolor".
> > 
> > I don't feel very strongly about this but it seems a little easier to
> understand
> > to me.
> > 
> > 
> > On 2013/07/10 15:01:26, dierk wrote:
> > > I used enums to match the style of the existing code. If I passed the
> GradData
> > > directly instead what would be the best way of appending something (in
this
> > case
> > > "_hicolor") to the name string to distinguish the new tests (in a readable
> > > fashion)? 
> > > 
> > > On 2013/07/09 21:29:45, bsalomon wrote:
> > > > Maybe just pass the GradData instance that you want to use directly and
> skip
> > > the
> > > > enum?
> > > 
> > 
> 
> Done.

lgtm

[commit-bot: I haz the power, 2013-07-10 15:47:25]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/dierk@google.com/18655012/9001

[commit-bot: I haz the power, 2013-07-10 16:13:16]

Change committed as 9960