Issue 18655007: Allow ico decoder to decode PNG sub-images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18655007: Allow ico decoder to decode PNG sub-images. (Closed)

Created:
7 years, 5 months ago by scroggo

Modified:
7 years, 5 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Allow ico decoder to decode PNG sub-images. Since Windows Vista, PNG can be embedded in an ICO file. Update our decoder to support this. BUG=https://code.google.com/p/skia/issues/detail?id=1398 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=9932

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -0 lines)			Patch
M	include/core/SkImageDecoder.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/images/SkImageDecoder.cpp	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/images/SkImageDecoder_libico.cpp	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

scroggo

7 years, 5 months ago (2013-07-09 15:48:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9932 (presubmit successful).