Add a quic_in_memory_cache_test data file.

Add a quic_in_memory_cache_test data file.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210314

[honghaiz, 2013-07-03 20:48:53]

Binary files seem not be able to be uploaded to the chromium repository. I
changed the data file to a purely text file and the test for
QuicInMemoryCacheTest passes and the data file is indeed uploaded now.

[Ryan Hamilton, 2013-07-03 21:55:49]

lgtm

[ramant (doing other things), 2013-07-03 22:01:14]

lgtm

[commit-bot: I haz the power, 2013-07-03 22:03:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/honghaiz@chromium.org/18655004/1003

[honghaiz, 2013-07-04 01:08:13]

I added code to fix the quic_unittests error. 
Sorry about the issue.

[Ryan Hamilton, 2013-07-04 14:46:03]

Thanks for doing this.

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
File net/tools/quic/quic_in_memory_cache.cc (right):

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
net/tools/quic/quic_in_memory_cache.cc:110: STLDeleteValues(&responses_);
I think you should call Initialize here, as well.

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
net/tools/quic/quic_in_memory_cache.cc:213: return
request_headers.GetHeader("host").as_string() + uri.as_string();
So if the host header is set and the URI is fully qualified this will do the
wrong thing, right?

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
File net/tools/quic/quic_in_memory_cache.h (right):

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
net/tools/quic/quic_in_memory_cache.h:73: friend class
test::QuicInMemoryCacheTest;
If you make ResetForTests call Initialize, then you won't need to add this
friend.

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
File net/tools/quic/quic_in_memory_cache_test.cc (right):

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
net/tools/quic/quic_in_memory_cache_test.cc:77: 
Can you add a test which pass with the new code, but fails with the old code.

[honghaiz, 2013-07-04 17:34:04]

PTAL

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
File net/tools/quic/quic_in_memory_cache.cc (right):

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
net/tools/quic/quic_in_memory_cache.cc:110: STLDeleteValues(&responses_);
On 2013/07/04 14:46:03, Ryan Hamilton wrote:
> I think you should call Initialize here, as well.

Done.

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
net/tools/quic/quic_in_memory_cache.cc:213: return
request_headers.GetHeader("host").as_string() + uri.as_string();
Fixed. 
On 2013/07/04 14:46:03, Ryan Hamilton wrote:
> So if the host header is set and the URI is fully qualified this will do the
> wrong thing, right?

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
File net/tools/quic/quic_in_memory_cache.h (right):

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
net/tools/quic/quic_in_memory_cache.h:73: friend class
test::QuicInMemoryCacheTest;
On 2013/07/04 14:46:03, Ryan Hamilton wrote:
> If you make ResetForTests call Initialize, then you won't need to add this
> friend.

Done.

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
File net/tools/quic/quic_in_memory_cache_test.cc (right):

https://codereview.chromium.org/18655004/diff/19001/net/tools/quic/quic_in_me...
net/tools/quic/quic_in_memory_cache_test.cc:77: 
On 2013/07/04 14:46:03, Ryan Hamilton wrote:
> Can you add a test which pass with the new code, but fails with the old code.

Done.

[Ryan Hamilton, 2013-07-04 18:55:40]

lgtm

[commit-bot: I haz the power, 2013-07-04 18:55:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/honghaiz@chromium.org/18655004/27001

[commit-bot: I haz the power, 2013-07-04 19:19:27]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-07-05 14:28:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/honghaiz@chromium.org/18655004/47001

[commit-bot: I haz the power, 2013-07-05 17:43:24]

Change committed as 210314