[Android] Add a gyp option to disable generating v14 resources script.

[Android] Add an gyp option to disable generating v14 resources script.

Currently, we are generating v14 layout and style resources from v17
resources by replacing Start and End attributes to Left and Right
attributes. However, it is not necessary for all cases, so make an
option to disable generate_v14_compatible_resources.py script and
only verify that there is no RTL attributes in the pre-v17 resources.

BUG=247049
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210555

[Kibeom Kim (inactive), 2013-07-03 17:23:47]

This is not ready for review yet, but this is the change I'm thinking. So we'll
be able to disable applying generate_v14_compatible_resources.py by putting 

'generate_v14_compatible_res': 0,

at the place where we have 

'has_java_resources': 1,

tested with https://gerrit-int.chromium.org/#/c/40016/.

[Kibeom Kim (inactive), 2013-07-08 12:32:56]

Added verification. Ready for review.

[newt (away), 2013-07-08 22:55:49]

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
File build/android/gyp/generate_v14_compatible_resources.py (right):

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:105: def
GenerateV14LayoutResourceDom(dom, filename_for_warning):
it's OK to print both a warning and an error if a layout file is not V14
compatible and --verify-only is used... and that seems cleaner. I'd just always
print the warning in this method (i.e. revert the changes in this method, and
always pass the filename to this method)

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:212: def
VerifyNoRtlAttributeInDir(input_dir):
how about "VerifyV14StyleResourcesInDir"?

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:215: if
(GenerateV14LayoutResourceDom(dom, None) or
it's a bit odd to run both of these methods on the dom. I'd split this into two
methods: "VerifyV14StyleResourcesInDir()" and "VerifyV14LayoutResourcesInDir()",
or just add an extra argument "verify_only" to GenerateV14StyleResourcesInDir
and related methods.

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:238:
parser.add_option('--only-verify', help='Do not generate v14 resources. '
"Do not generate v14 resources. Instead, just verify that the resources are
already compatible with v14, i.e. they don't use attributes that cause crashes
on certain devices."

nit: "--verify-only" seems better (put the most important part first)

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:240: 'cause crashes on
certain devices.')
use 'action="store_true"' here. then options.only_verify will be either True or
False, and you can remove line 255.

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:255: only_verify =
bool(options.only_verify) and int(options.only_verify) > 0
remove this

[Kibeom Kim (inactive), 2013-07-09 00:20:50]

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
File build/android/gyp/generate_v14_compatible_resources.py (right):

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:105: def
GenerateV14LayoutResourceDom(dom, filename_for_warning):
On 2013/07/08 22:55:49, newt wrote:
> it's OK to print both a warning and an error if a layout file is not V14
> compatible and --verify-only is used... and that seems cleaner. I'd just
always
> print the warning in this method (i.e. revert the changes in this method, and
> always pass the filename to this method)

Looks like we have to skip warning for pre-v17 because it will contain
Left/Right attribute, and keep warning for v17. So I guess we still need a way
to disable the warning.

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:212: def
VerifyNoRtlAttributeInDir(input_dir):
On 2013/07/08 22:55:49, newt wrote:
> how about "VerifyV14StyleResourcesInDir"?

Done.

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:215: if
(GenerateV14LayoutResourceDom(dom, None) or
On 2013/07/08 22:55:49, newt wrote:
> it's a bit odd to run both of these methods on the dom. I'd split this into
two
> methods: "VerifyV14StyleResourcesInDir()" and
"VerifyV14LayoutResourcesInDir()",
> or just add an extra argument "verify_only" to GenerateV14StyleResourcesInDir
> and related methods.

Done.

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:238:
parser.add_option('--only-verify', help='Do not generate v14 resources. '
On 2013/07/08 22:55:49, newt wrote:
> "Do not generate v14 resources. Instead, just verify that the resources are
> already compatible with v14, i.e. they don't use attributes that cause crashes
> on certain devices."
> 
> nit: "--verify-only" seems better (put the most important part first)

Done.

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:240: 'cause crashes on
certain devices.')
On 2013/07/08 22:55:49, newt wrote:
> use 'action="store_true"' here. then options.only_verify will be either True
or
> False, and you can remove line 255.

Done.

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:255: only_verify =
bool(options.only_verify) and int(options.only_verify) > 0
On 2013/07/08 22:55:49, newt wrote:
> remove this

Done.

[newt (away), 2013-07-09 00:52:49]

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
File build/android/gyp/generate_v14_compatible_resources.py (right):

https://codereview.chromium.org/18653002/diff/2001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:105: def
GenerateV14LayoutResourceDom(dom, filename_for_warning):
On 2013/07/09 00:20:50, Kibeom Kim wrote:
> On 2013/07/08 22:55:49, newt wrote:
> > it's OK to print both a warning and an error if a layout file is not V14
> > compatible and --verify-only is used... and that seems cleaner. I'd just
> always
> > print the warning in this method (i.e. revert the changes in this method,
and
> > always pass the filename to this method)
> 
> Looks like we have to skip warning for pre-v17 because it will contain
> Left/Right attribute, and keep warning for v17. So I guess we still need a way
> to disable the warning.

Where is that call? I only see this method called in two places: lines 170 (with
a filename) and 215 (with None, though we could replace it with a filename)

https://codereview.chromium.org/18653002/diff/8001/build/android/gyp/generate...
File build/android/gyp/generate_v14_compatible_resources.py (right):

https://codereview.chromium.org/18653002/diff/8001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:203: 
python style is two newlines between top-level methods or classes

https://codereview.chromium.org/18653002/diff/8001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:305: if resource_type in
('layout', 'xml'):
this logic (lines 305-310) probably belongs inside VerifyV14ResourcesInDir

https://codereview.chromium.org/18653002/diff/8001/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/18653002/diff/8001/build/java.gypi#newcode189
build/java.gypi:189: 'res_v14_verify_only%': 0,
res_v14_verify_only should probably go at the top of this file with the other
variables, since it's a configurable parameter when including java.gypi

(everything else should stay down here)

[Kibeom Kim (inactive), 2013-07-09 02:10:20]

https://codereview.chromium.org/18653002/diff/8001/build/android/gyp/generate...
File build/android/gyp/generate_v14_compatible_resources.py (right):

https://codereview.chromium.org/18653002/diff/8001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:203: 
On 2013/07/09 00:52:49, newt wrote:
> python style is two newlines between top-level methods or classes

Done.

https://codereview.chromium.org/18653002/diff/8001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:305: if resource_type in
('layout', 'xml'):
On 2013/07/09 00:52:49, newt wrote:
> this logic (lines 305-310) probably belongs inside VerifyV14ResourcesInDir

Done.

https://codereview.chromium.org/18653002/diff/8001/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/18653002/diff/8001/build/java.gypi#newcode189
build/java.gypi:189: 'res_v14_verify_only%': 0,
On 2013/07/09 00:52:49, newt wrote:
> res_v14_verify_only should probably go at the top of this file with the other
> variables, since it's a configurable parameter when including java.gypi
> 
> (everything else should stay down here)

Done.

[newt (away), 2013-07-09 02:12:14]

lgtm

[commit-bot: I haz the power, 2013-07-09 02:12:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/18653002/20001

[commit-bot: I haz the power, 2013-07-09 14:07:53]

Change committed as 210555