Deploy adb reconnect on disconnect daemon on WebKit Android bots.

Deploy adb reconnect on disconnect daemon on WebKit (ContentShell) Android bot.

NOTRY=True
BUG=256353
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211283

[navabi, 2013-07-03 23:19:11]

This CL requires 'adb root' which we currently do not do on the bots. Please
refer to the bug for discussion.

[Isaac (away), 2013-07-04 01:57:03]

https://codereview.chromium.org/18652008/diff/1/build/android/buildbot/bb_dev...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/18652008/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:254: if options.auto_reconnect:
provision_cmd = [...]
if options.auto_reconnect:
  provision_cmd.append('--auto-reconnect')
RunCmd(provision_cmd)

[navabi1, 2013-07-08 17:17:27]

https://codereview.chromium.org/18652008/diff/1/build/android/buildbot/bb_dev...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/18652008/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:254: if options.auto_reconnect:
On 2013/07/04 01:57:04, Isaac wrote:
> provision_cmd = [...]
> if options.auto_reconnect:
>   provision_cmd.append('--auto-reconnect')
> RunCmd(provision_cmd)

Done.

[Isaac (away), 2013-07-08 17:47:38]

This lgtm but lacks trybot coverage.  I'd suggest temporarily modifying your
patch so it affects android_dbg target and sending to that trybot for
verification.  If the webkit bots are useless right now it would be OK to land
and monitor the bots.

[navabi, 2013-07-08 17:51:00]

Thanks Isaac. The webkit bots are useless right now (e.g.
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20(Content%20Shel...)
so I would like to land and monitor the bots, but first I'd like to test
and see if 'su' works instead of 'adb root', as that will be necessary for
the daemon to work. Once I figure that at, I'll update the CL.


On Mon, Jul 8, 2013 at 10:47 AM, <ilevy@chromium.org> wrote:

> This lgtm but lacks trybot coverage.  I'd suggest temporarily modifying
> your
> patch so it affects android_dbg target and sending to that trybot for
> verification.  If the webkit bots are useless right now it would be OK to
> land
> and monitor the bots.
>
>
https://codereview.chromium.**org/18652008/<https://codereview.chromium.org/1...
>

[navabi, 2013-07-11 23:50:28]

The WebKit bots have actually started having green builds, so they are not
useless. As such, I tried on the try bots which turned out to be a good idea, as
I made the following changes as a result of running on the try bot:

1) push to /data/local/tmp/ instead of /data/local/. /data/local/ does not have
permission to push to.

2) Need to kill host_heartbeat or buildbot script gets stuck.

3) With the new confidence of running on the try bots, I added the
adb_reboot_on_disconnect daemon to the WebKitAndroidGN bot, as historically, it
has had the most problems with 'offline' devices.

[commit-bot: I haz the power, 2013-07-11 23:52:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/18652008/46001

[commit-bot: I haz the power, 2013-07-12 01:40:10]

Change committed as 211283