Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 18648011: Implement Promise.fulfill, Promise.resolve and Promise.reject. (Closed)

Created:
7 years, 5 months ago by yhirano
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Implement Promise.fulfill, Promise.resolve and Promise.reject. We are implementing DOM/promises[1]. We implement Promise.fulfill, Promise.resolve and Promise.reject in this CL. [1] http://dom.spec.whatwg.org/#promises BUG=243345 R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153747

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -17 lines) Patch
A + LayoutTests/fast/js/Promise-static-fulfill.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + LayoutTests/fast/js/Promise-static-fulfill-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-static-reject.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + LayoutTests/fast/js/Promise-static-reject-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-static-resolve.html View 1 1 chunk +8 lines, -5 lines 0 comments Download
A + LayoutTests/fast/js/Promise-static-resolve-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download
M Source/core/dom/Promise.idl View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yhirano
7 years, 5 months ago (2013-07-04 09:34:21 UTC) #1
abarth-chromium
lgtm
7 years, 5 months ago (2013-07-08 18:48:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/18648011/4001
7 years, 5 months ago (2013-07-08 18:49:49 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-08 19:07:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/18648011/22001
7 years, 5 months ago (2013-07-09 01:35:29 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Promise.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-09 01:35:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/18648011/11002
7 years, 5 months ago (2013-07-09 02:02:59 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 05:39:00 UTC) #8
Message was sent while issue was closed.
Change committed as 153747

Powered by Google App Engine
This is Rietveld 408576698