Issue 18648003: Let JsonDoubleQuote accept StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18648003: Let JsonDoubleQuote accept StringPiece (Closed)

Created:
7 years, 5 months ago by Xianzhu

Modified:
7 years, 3 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, erikwright+watch_chromium.org, nduca

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Let JsonDoubleQuote accept StringPiece So that the functions can escape 'const char*' or 'const char16*' without creating a std::string or string16 object for the parameter. BUG=none TEST=StringEscapeTest.JsonDoubleQuoteNarrow Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221625

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -11 lines)			Patch
M	base/json/string_escape.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	base/json/string_escape.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	base/json/string_escape_unittest.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Xianzhu

Made this CL because I need the functions in https://codereview.chromium.org/18083015/, but don't want the extra ...

7 years, 5 months ago (2013-07-03 17:57:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/18648003/1

7 years, 3 months ago (2013-09-06 01:17:14 UTC) #4

Message was sent while issue was closed.

Change committed as 221625

Expand Messages | Collapse Messages