[sql] Retry Open() if error handler fixed things.

sql/connection_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/logging.h"
 #include "sql/connection.h"
 #include "sql/meta_table.h"
@@ skipping 473 matching lines @@
   EXPECT_TRUE(db().Raze());
   db().Close();
 
   // Now empty, the open should succeed with an empty database.
   EXPECT_TRUE(db().Open(db_path()));
   EXPECT_EQ(0, SqliteMasterCount(&db()));
 }
 
 // Test that a callback from Open() can raze the database.  This is
 // essential for cases where the Open() can fail entirely, so the
-// Raze() cannot happen later.
+// Raze() cannot happen later.  Additionally test that when the
+// callback does this during Open(), the open is retried and succeeds.
 //
 // Most corruptions seen in the wild seem to happen when two pages in
 // the database were not written transactionally (the transaction
 // changed both, but one wasn't successfully written for some reason).
 // A special case of that is when the header indicates that the
 // database contains more pages than are in the file.  This breaks
 // things at a very basic level, verify that Raze() can handle it.
-TEST_F(SQLConnectionTest, RazeOpenCallback) {
+TEST_F(SQLConnectionTest, RazeCallbackReopen) {
   const char* kCreateSql = "CREATE TABLE foo (id INTEGER PRIMARY KEY, value)";
   ASSERT_TRUE(db().Execute(kCreateSql));
   ASSERT_EQ(1, SqliteMasterCount(&db()));
   int page_size = 0;
   {
     sql::Statement s(db().GetUniqueStatement("PRAGMA page_size"));
     ASSERT_TRUE(s.Step());
     page_size = s.ColumnInt(0);
   }
   db().Close();
 
   // Trim a single page from the end of the file.
   {
     file_util::ScopedFILE file(file_util::OpenFile(db_path(), "r+"));
     ASSERT_TRUE(file.get() != NULL);
     ASSERT_EQ(0, fseek(file.get(), -page_size, SEEK_END));
     ASSERT_TRUE(file_util::TruncateFile(file.get()));
   }
 
+  // Open() will succeed, even though the PRAGMA calls within will
+  // fail with SQLITE_CORRUPT, as will this PRAGMA.
+  {
+    sql::ScopedErrorIgnorer ignore_errors;
+    ignore_errors.IgnoreError(SQLITE_CORRUPT);
+    ASSERT_TRUE(db().Open(db_path()));
+    ASSERT_FALSE(db().Execute("PRAGMA auto_vacuum"));
+    db().Close();
+    ASSERT_TRUE(ignore_errors.CheckIgnoredErrors());
+  }
+
   db().set_error_callback(base::Bind(&SQLConnectionTest::RazeErrorCallback,
                                      base::Unretained(this),
                                      SQLITE_CORRUPT));
 
-  // Open() will see SQLITE_CORRUPT due to size mismatch when
-  // attempting to run a pragma, and the callback will RazeAndClose().
-  // Later statements will fail, including the final secure_delete,
-  // which will fail the Open() itself.
-  ASSERT_FALSE(db().Open(db_path()));
-  db().Close();
-
-  // Now empty, the open should succeed with an empty database.
-  EXPECT_TRUE(db().Open(db_path()));
+  // When the PRAGMA calls in Open() raise SQLITE_CORRUPT, the error
+  // callback will call RazeAndClose().  Open() will then fail and be
+  // retried.  The second Open() on the empty database will succeed
+  // cleanly.
+  ASSERT_TRUE(db().Open(db_path()));
+  ASSERT_TRUE(db().Execute("PRAGMA auto_vacuum"));
   EXPECT_EQ(0, SqliteMasterCount(&db()));
 }
 
 // Basic test of RazeAndClose() operation.
 TEST_F(SQLConnectionTest, RazeAndClose) {
   const char* kCreateSql = "CREATE TABLE foo (id INTEGER PRIMARY KEY, value)";
   const char* kPopulateSql = "INSERT INTO foo (value) VALUES (12)";
 
   // Test that RazeAndClose() closes the database, and that the
   // database is empty when re-opened.
@@ skipping 111 matching lines @@
   base::FilePath journal(db_path().value() + FILE_PATH_LITERAL("-journal"));
   ASSERT_TRUE(base::PathExists(db_path()));
   ASSERT_TRUE(base::PathExists(journal));
 
   sql::Connection::Delete(db_path());
   EXPECT_FALSE(base::PathExists(db_path()));
   EXPECT_FALSE(base::PathExists(journal));
 }
 
 }  // namespace