Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 18641004: [sql] Retry Open() if error handler fixed things. (Closed)

Created:
7 years, 5 months ago by Scott Hess - ex-Googler
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[sql] Retry Open() if error handler fixed things. Since the caller cannot have existing database-derived state before the database is opened, Open() can be safely retried after the error handler has razed the database. BUG=109482 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211936

Patch Set 1 #

Patch Set 2 : Pointless tweaking, rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -18 lines) Patch
M sql/connection.h View 1 1 chunk +8 lines, -1 line 0 comments Download
M sql/connection.cc View 1 5 chunks +13 lines, -6 lines 0 comments Download
M sql/connection_unittest.cc View 1 3 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Hess - ex-Googler
Starting to wire the pieces together. The recovery code will also poison things, so with ...
7 years, 5 months ago (2013-07-16 21:15:43 UTC) #1
erikwright (departed)
LGTM.
7 years, 5 months ago (2013-07-16 23:49:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/18641004/3001
7 years, 5 months ago (2013-07-17 00:06:53 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 04:45:17 UTC) #4
Message was sent while issue was closed.
Change committed as 211936

Powered by Google App Engine
This is Rietveld 408576698