Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: appengine/logdog/coordinator/backend/util_test.go

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors
Patch Set: Fix proto comment. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/logdog/coordinator/backend/util.go ('k') | appengine/logdog/coordinator/config/auth.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/logdog/coordinator/backend/util_test.go
diff --git a/appengine/logdog/coordinator/backend/util_test.go b/appengine/logdog/coordinator/backend/util_test.go
index 59a237fc7e7820835cc0f7a4671aca1788c894ee..ac65bbdc3dcb911db2960a20a345a3f946c70a4b 100644
--- a/appengine/logdog/coordinator/backend/util_test.go
+++ b/appengine/logdog/coordinator/backend/util_test.go
@@ -6,16 +6,10 @@ package backend
import (
"net/http"
- "sort"
"github.com/julienschmidt/httprouter"
- tq "github.com/luci/gae/service/taskqueue"
- "github.com/luci/luci-go/appengine/logdog/coordinator"
- "github.com/luci/luci-go/common/logdog/types"
"github.com/luci/luci-go/server/middleware"
"golang.org/x/net/context"
-
- . "github.com/smartystreets/goconvey/convey"
)
// testBase is a middleware.Base which uses its current Context as the base
@@ -29,24 +23,3 @@ func (t *testBase) base(h middleware.Handler) httprouter.Handle {
h(t.Context, w, r, p)
}
}
-
-func shouldHaveTasks(actual interface{}, expected ...interface{}) string {
- a := actual.(map[string]*tq.Task)
- al := make([]string, 0, len(a))
- for _, t := range a {
- al = append(al, t.Name)
- }
-
- tasks := make([]string, len(expected))
- for i, t := range expected {
- tasks[i] = t.(string)
- }
-
- sort.Strings(al)
- sort.Strings(tasks)
- return ShouldResemble(al, tasks)
-}
-
-func archiveTaskName(path string) string {
- return archiveTaskNameForHash(coordinator.LogStreamFromPath(types.StreamPath(path)).HashID())
-}
« no previous file with comments | « appengine/logdog/coordinator/backend/util.go ('k') | appengine/logdog/coordinator/config/auth.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698