Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: appengine/logdog/coordinator/endpoints/services/registerStream.go

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors
Patch Set: Code review comments, use Pub/Sub, archival staging, quality of life. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/logdog/coordinator/endpoints/services/registerStream.go
diff --git a/appengine/logdog/coordinator/endpoints/services/registerStream.go b/appengine/logdog/coordinator/endpoints/services/registerStream.go
index 9b0535beada586286be12ae0b32b7d751de96e0b..3af68d6efdfc7a4cab30cf24555bd7ac6268830f 100644
--- a/appengine/logdog/coordinator/endpoints/services/registerStream.go
+++ b/appengine/logdog/coordinator/endpoints/services/registerStream.go
@@ -62,9 +62,9 @@ func loadLogStreamState(ls *coordinator.LogStream) *logdog.LogStreamState {
}
// RegisterStream is an idempotent stream state register operation.
-func (b *Server) RegisterStream(c context.Context, req *logdog.RegisterStreamRequest) (
- *logdog.RegisterStreamResponse, error) {
- if err := Auth(c); err != nil {
+func (s *Server) RegisterStream(c context.Context, req *logdog.RegisterStreamRequest) (*logdog.RegisterStreamResponse, error) {
+ svc := s.GetServices()
+ if err := Auth(c, svc); err != nil {
return nil, err
}
@@ -181,15 +181,13 @@ func (m registerStreamMutation) RollForward(c context.Context) ([]tumble.Mutatio
return nil, grpcutil.Errf(codes.InvalidArgument, "Failed to load descriptor.")
}
- now := ds.RoundTime(clock.Now(c).UTC())
m.Secret = m.req.Secret
m.ProtoVersion = m.req.ProtoVersion
- m.State = coordinator.LSPending
- m.Created = now
- m.Updated = now
+ m.State = coordinator.LSStreaming
+ m.Created = ds.RoundTime(clock.Now(c).UTC())
m.TerminalIndex = -1
- if err := m.Put(di); err != nil {
+ if err := di.Put(m.LogStream); err != nil {
log.Fields{
log.ErrorKey: err,
}.Errorf(c, "Failed to Put() LogStream.")

Powered by Google App Engine
This is Rietveld 408576698