Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2283)

Unified Diff: appengine/logdog/coordinator/endpoints/logs/service.go

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors
Patch Set: Code review comments, use Pub/Sub, archival staging, quality of life. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/logdog/coordinator/endpoints/logs/service.go
diff --git a/appengine/logdog/coordinator/endpoints/logs/service.go b/appengine/logdog/coordinator/endpoints/logs/service.go
index fc0ee679322da41472f02589765f3ce901c86049..c41d76ce85677b7edd2fe59e8890d1ac0c195977 100644
--- a/appengine/logdog/coordinator/endpoints/logs/service.go
+++ b/appengine/logdog/coordinator/endpoints/logs/service.go
@@ -11,7 +11,7 @@ import (
// Server is the user-facing log access and query endpoint service.
type Server struct {
- coordinator.Service
+ coordinator.ServiceBase
// resultLimit is the maximum number of query results to return in a
// single query. If zero, the default will be used.
@@ -20,6 +20,8 @@ type Server struct {
resultLimit int
}
+var _ logdog.LogsServer = (*Server)(nil)
+
func (s *Server) limit(v int, d int) int {
if s.resultLimit > 0 {
d = s.resultLimit
@@ -29,5 +31,3 @@ func (s *Server) limit(v int, d int) int {
}
return v
}
-
-var _ logdog.LogsServer = (*Server)(nil)

Powered by Google App Engine
This is Rietveld 408576698