Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 18637004: Sets the background color of shelf is opaque black when maximized (2nd) (Closed)

Created:
7 years, 5 months ago by Jun Mukai
Modified:
7 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Sets the background color of shelf is opaque black when maximized (2nd) Previously the black color was achieved by hiding the desktop background. Now shelf's background color is opaque black instead. The first patch (r210763) was reverted due to test failure in win8. BUG=252422 TEST=covered by the new tests TBR=jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211053

Patch Set 1 #

Patch Set 2 : log injection #

Patch Set 3 : ideal bounds #

Patch Set 4 : remove log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -141 lines) Patch
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.h View 5 chunks +9 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 5 chunks +41 lines, -17 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
M ash/shelf/shelf_types.h View 1 chunk +11 lines, -0 lines 0 comments Download
M ash/shelf/shelf_widget.h View 1 chunk +3 lines, -6 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 11 chunks +55 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +34 lines, -22 lines 0 comments Download
M ash/wm/workspace/workspace_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 4 chunks +1 line, -42 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 3 chunks +3 lines, -48 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jun Mukai
submit with TBR=jamescook because the previous patch was already approved. The only change from the ...
7 years, 5 months ago (2013-07-10 19:50:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/18637004/9001
7 years, 5 months ago (2013-07-10 19:51:09 UTC) #2
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-10 19:59:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/18637004/9001
7 years, 5 months ago (2013-07-10 20:12:41 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 09:33:03 UTC) #5
Message was sent while issue was closed.
Change committed as 211053

Powered by Google App Engine
This is Rietveld 408576698