Chromium Code Reviews Chromium Code Reviews
Issue 18629003:
MediaStreamAudioDestinationNode should inherit AudioNode (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 | 2 |
| 3 <html> | 3 <html> |
| 4 <head> | 4 <head> |
| 5 <script src="../fast/js/resources/js-test-pre.js"></script> | 5 <script src="../fast/js/resources/js-test-pre.js"></script> |
| 6 <script src="resources/audio-testing.js"></script> | 6 <script src="resources/audio-testing.js"></script> |
| 7 </head> | 7 </head> |
| 8 | 8 |
| 9 <body> | 9 <body> |
| 10 <div id="description"></div> | 10 <div id="description"></div> |
| 11 <div id="console"></div> | 11 <div id="console"></div> |
| 12 | 12 |
| 13 <script> | 13 <script> |
| 14 description("Basic tests for MediaStreamAudioDestinationNode API."); | 14 description("Basic tests for MediaStreamAudioDestinationNode API."); |
| 15 | 15 |
| 16 var context = 0; | 16 var context = 0; |
| 17 var mediaStreamDestination = 0; | |
|
arv (Not doing code reviews)
2013/07/08 21:35:43
why 0?
do-not-use
2013/07/09 06:37:28
For consistency with the line above but this is no
| |
| 17 | 18 |
| 18 function runTest() { | 19 function runTest() { |
| 19 if (window.testRunner) { | 20 if (window.testRunner) { |
| 20 testRunner.dumpAsText(); | 21 testRunner.dumpAsText(); |
| 21 } | 22 } |
| 22 | 23 |
| 23 context = new webkitAudioContext(); | 24 context = new webkitAudioContext(); |
| 24 | 25 |
| 25 var mediaStreamDestination = context.createMediaStreamDestination(); | 26 mediaStreamDestination = context.createMediaStreamDestination(); |
| 27 | |
| 28 // MediaStreamAudioDestinationNode should inherit AudioNode. | |
| 29 shouldBe('mediaStreamDestination.__proto__.__proto__', 'AudioNode.prototype' ); | |
| 26 | 30 |
| 27 // Check number of inputs and outputs. | 31 // Check number of inputs and outputs. |
| 28 if (mediaStreamDestination.numberOfInputs == 1) | 32 if (mediaStreamDestination.numberOfInputs == 1) |
| 29 testPassed("Destination AudioNode has one input."); | 33 testPassed("Destination AudioNode has one input."); |
| 30 else | 34 else |
| 31 testFailed("Destination AudioNode should have one input."); | 35 testFailed("Destination AudioNode should have one input."); |
| 32 | 36 |
| 33 // FIXME: We should have no outputs, but since we're implemented using Audio BasicInspectorNode | 37 // FIXME: We should have no outputs, but since we're implemented using Audio BasicInspectorNode |
| 34 // we have one. | 38 // we have one. |
| 35 // if (mediaStreamDestination.numberOfOutputs == 0) | 39 // if (mediaStreamDestination.numberOfOutputs == 0) |
| 36 // testPassed("Destination AudioNode has no outputs."); | 40 // testPassed("Destination AudioNode has no outputs."); |
| 37 // else | 41 // else |
| 38 // testFailed("Destination AudioNode should not have outputs."); | 42 // testFailed("Destination AudioNode should not have outputs."); |
| 39 | 43 |
| 40 // FIXME: add a test where we create a PeerConnection and call addStream(med iaStreamDestination.stream). | 44 // FIXME: add a test where we create a PeerConnection and call addStream(med iaStreamDestination.stream). |
| 41 | 45 |
| 42 finishJSTest(); | 46 finishJSTest(); |
| 43 } | 47 } |
| 44 | 48 |
| 45 runTest(); | 49 runTest(); |
| 46 window.successfullyParsed = true; | 50 window.successfullyParsed = true; |
| 47 | 51 |
| 48 </script> | 52 </script> |
| 49 | 53 |
| 50 <script src="../fast/js/resources/js-test-post.js"></script> | 54 <script src="../fast/js/resources/js-test-post.js"></script> |
| 51 </body> | 55 </body> |
| 52 </html> | 56 </html> |
| OLD | NEW |
