chrome/browser/extensions/api/context_menus/context_menus_api.cc - Issue 186213003: <webview>: Context menu API implementation CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/context_menus/context_menus_api.cc

Issue 186213003: <webview>: Context menu API implementation CL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make {extension_id,webview_instance_id} key for MenuManager items. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/context_menus/context_menus_api.cc

diff --git a/chrome/browser/extensions/api/context_menus/context_menus_api.cc b/chrome/browser/extensions/api/context_menus/context_menus_api.cc

index 4c5e6b56836793889b47030d056be76300a18a56..3327d6953ae87e4aa20fdcd442dfe7ab32456869 100644

--- a/chrome/browser/extensions/api/context_menus/context_menus_api.cc

+++ b/chrome/browser/extensions/api/context_menus/context_menus_api.cc

@@ -102,7 +102,7 @@ bool ContextMenusRemoveFunction::RunImpl() {

bool ContextMenusRemoveAllFunction::RunImpl() {

MenuManager* manager = MenuManager::Get(GetProfile());

- manager->RemoveAllContextItems(GetExtension()->id());

+ manager->RemoveAllContextItems(MenuItem::ExtensionKey(GetExtension()->id()));

manager->WriteToStorage(GetExtension());

return true;

}