chrome/renderer/resources/extensions/webview_custom_bindings.js - Issue 186213003: <webview>: Context menu API implementation CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/webview_custom_bindings.js

Issue 186213003: <webview>: Context menu API implementation CL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test + fixed MenuManager::ExtensionIds(). Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/webview_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/webview_custom_bindings.js b/chrome/renderer/resources/extensions/webview_custom_bindings.js

index 3eb96cd34353bfa6e07e2826d1ffac233b8e3596..1625021f48a34e6805c01c13311a8f726a556bb2 100644

--- a/chrome/renderer/resources/extensions/webview_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/webview_custom_bindings.js

@@ -56,6 +56,7 @@ binding.registerCustomHook(function(bindingsAPI) {

// if there is one.

var id = arguments[0].menuItemId;

var instanceId = arguments[0].webviewInstanceId;

+ delete arguments[0].webviewInstanceId;

var onclick = webviewContextMenus.handlersForId(instanceId, id)[id];

if (onclick) {

$Function.apply(onclick, null, arguments);