chrome/browser/guestview/webview/webview_guest.h - Issue 186213003: <webview>: Context menu API implementation CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guestview/webview/webview_guest.h

Issue 186213003: <webview>: Context menu API implementation CL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test + fixed MenuManager::ExtensionIds(). Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/guestview/webview/webview_guest.h

diff --git a/chrome/browser/guestview/webview/webview_guest.h b/chrome/browser/guestview/webview/webview_guest.h

index e88712c4922f537ec5070a05807f55edac459070..c68214c751960c0055a6c00f7cf9ca21770fd1bf 100644

--- a/chrome/browser/guestview/webview/webview_guest.h

+++ b/chrome/browser/guestview/webview/webview_guest.h

@@ -38,6 +38,8 @@ class WebViewGuest : public GuestView,

static WebViewGuest* From(int embedder_process_id, int instance_id);

static WebViewGuest* FromWebContents(content::WebContents* contents);

+ // Returns 0 if |contents| does not correspond to a WebViewGuest.

Yoyo Zhou 2014/03/07 02:40:30 Why not say kInstanceIDNone?

lazyboy 2014/03/07 06:38:03 Done.

+ static int GetViewInstanceId(content::WebContents* contents);

// GuestView implementation.

virtual void Attach(content::WebContents* embedder_web_contents,