Issue 18621002: Make MachO gdbjit support compile again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18621002: Make MachO gdbjit support compile again (Closed)

Created:
7 years, 5 months ago by danno

Modified:
7 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make MachO gdbjit support compile again R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15460

Patch Set 1 #

Patch Set 2 : Remove stray flag toggles #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	src/gdb-jit.cc	View		5 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

7 years, 5 months ago (2013-07-03 11:53:07 UTC) #4

Message was sent while issue was closed.

It compiles, but does not work. Please see
https://codereview.chromium.org/13083002/ for more information.

In the future, we should make lldb work for V8 jit on Mac as gdb remains 6.3.50
on Mac but gdbjit requires 7.0. When I have free time, I will have a try :)

Expand Messages | Collapse Messages