Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 18612007: IndexedDB: Remove transaction timer, just post tasks (Closed)

Created:
7 years, 5 months ago by jsbell
Modified:
7 years, 5 months ago
Reviewers:
alecflett, dgrogan
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

IndexedDB: Remove transaction timer, just post tasks In the Blink implementation transactions used a timer to keep to schedule asynchronous processing of tasks. This was retained in the Chromium port, but with access to the message loop we can post tasks instead. Note that transactions still maintain an internal list of tasks and all that is posted is a "process the queue" task. Future changes may integrate the transaction task queue and the message loop more tightly. BUG=246629 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210969

Patch Set 1 #

Patch Set 2 : Rename variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M content/browser/indexed_db/indexed_db_transaction.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.cc View 1 6 chunks +25 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
alecflett@, dgrogan@ - please take a look?
7 years, 5 months ago (2013-07-10 17:38:40 UTC) #1
dgrogan
lgtm This is an attempt to handle a performance regression right? "process_queue_" was a little ...
7 years, 5 months ago (2013-07-10 18:35:13 UTC) #2
jsbell
On 2013/07/10 18:35:13, dgrogan wrote: > lgtm > > This is an attempt to handle ...
7 years, 5 months ago (2013-07-10 18:41:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/18612007/5001
7 years, 5 months ago (2013-07-10 19:08:08 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 23:37:16 UTC) #5
Message was sent while issue was closed.
Change committed as 210969

Powered by Google App Engine
This is Rietveld 408576698