Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: media/cast/test/end2end_unittest.cc

Issue 186043003: Cast: Using a min filter to compute time offset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated test and rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/cast/video_receiver/video_receiver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/test/end2end_unittest.cc
diff --git a/media/cast/test/end2end_unittest.cc b/media/cast/test/end2end_unittest.cc
index 71b2c3e307b4909c847e19b2424b7b22b8c1c9d6..8c23e3e28605e4ac73d430080acea059e521610d 100644
--- a/media/cast/test/end2end_unittest.cc
+++ b/media/cast/test/end2end_unittest.cc
@@ -894,21 +894,24 @@ TEST_F(End2EndTest, GlitchWith3Buffers) {
Create();
int video_start = kVideoStart;
- base::TimeTicks send_time = testing_clock_sender_->NowTicks();
- SendVideoFrame(video_start, send_time);
- RunTasks(kFrameTimerMs);
-
- test_receiver_video_callback_->AddExpectedResult(video_start,
- video_sender_config_.width,
- video_sender_config_.height,
- send_time);
- frame_receiver_->GetRawVideoFrame(
- base::Bind(&TestReceiverVideoCallback::CheckVideoFrame,
- test_receiver_video_callback_));
-
- RunTasks(750); // Make sure that we send a RTCP packet.
-
- video_start++;
+ base::TimeTicks send_time;
+ // Frames will rendered on completion until the render time stabilizes, i.e.
+ // we got enough data.
+ const int frames_before_glitch = 20;
+ for (int i = 0; i < frames_before_glitch; ++i) {
+ send_time = testing_clock_sender_->NowTicks();
+ SendVideoFrame(video_start, send_time);
+ test_receiver_video_callback_->AddExpectedResult(
+ video_start,
+ video_sender_config_.width,
+ video_sender_config_.height,
+ send_time);
+ frame_receiver_->GetRawVideoFrame(
+ base::Bind(&TestReceiverVideoCallback::CheckVideoFrame,
+ test_receiver_video_callback_));
+ RunTasks(kFrameTimerMs);
+ video_start++;
+ }
// Introduce a glitch lasting for 10 frames.
sender_to_receiver_.SetSendPackets(false);
@@ -939,7 +942,8 @@ TEST_F(End2EndTest, GlitchWith3Buffers) {
test_receiver_video_callback_));
RunTasks(2 * kFrameTimerMs + 1); // Empty the receiver pipeline.
- EXPECT_EQ(2, test_receiver_video_callback_->number_times_called());
+ EXPECT_EQ(frames_before_glitch + 1,
+ test_receiver_video_callback_->number_times_called());
}
TEST_F(End2EndTest, DropEveryOtherFrame3Buffers) {
@@ -986,7 +990,7 @@ TEST_F(End2EndTest, ResetReferenceFrameId) {
sender_to_receiver_.AlwaysResetReferenceFrameId();
int frames_counter = 0;
- for (; frames_counter < 20; ++frames_counter) {
+ for (; frames_counter < 10; ++frames_counter) {
const base::TimeTicks send_time = testing_clock_sender_->NowTicks();
SendVideoFrame(frames_counter, send_time);
« no previous file with comments | « no previous file | media/cast/video_receiver/video_receiver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698