Issue 18603010: Fix tests for nag_max=30.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18603010: Fix tests for nag_max=30. (Closed)

Created:
7 years, 5 months ago by iannucci

Modified:
7 years, 5 months ago

Reviewers:
Jói

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Fix tests for nag_max=30. Test breakage introduced by f10ffa9069e8af3a71d8d3ccf0e71adc5bcf364b. TBR=joi@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=210220

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tests/gclient_scm_test.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/18603010/1

7 years, 5 months ago (2013-07-04 20:20:02 UTC) #2

Jói

LGTM Whoops, very sorry about that, I had test errors but I thought I had ...

7 years, 5 months ago (2013-07-04 20:32:32 UTC) #4

iannucci

7 years, 5 months ago (2013-07-04 20:34:22 UTC) #5

Message was sent while issue was closed.

On 2013/07/04 20:32:32, Jói wrote:
> LGTM
> 
> Whoops, very sorry about that, I had test errors but I thought I had
> verified they all seemed to be because of some obscure SVN stuff,
> unrelated to the nag timer.  Absolutely my bad, apologies.
> 
> Cheers,
> Jói
> 
> 
> On Thu, Jul 4, 2013 at 8:21 PM,  <mailto:commit-bot@chromium.org> wrote:
> > Change committed as 210220
> >
> > https://chromiumcodereview.appspot.com/18603010/

No problem at all, happy to help :)

Some of those test fails can be pretty cryptic...

Expand Messages | Collapse Messages