Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc

Issue 18603006: Bookmark sync promo for Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test for CrOS Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
index a410d2b704a5376d6d353af2cecd60abe047163b..5b51aaa5214276a8a29191273d8a86556395fcc7 100644
--- a/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
@@ -31,6 +31,8 @@ enum {
UMA_APP_LAUNCHER_SIGNED_IN,
UMA_APPS_PAGE_LINK_SHOWN,
UMA_APPS_PAGE_LINK_SIGNED_IN,
+ UMA_BOOKMARK_BUBBLE_SHOWN,
+ UMA_BOOKMARK_BUBBLE_SIGNED_IN,
UMA_MAX,
};
@@ -67,6 +69,9 @@ void RecordUserShownPromo(content::WebUI* web_ui) {
case SyncPromoUI::SOURCE_APPS_PAGE_LINK:
uma = UMA_APPS_PAGE_LINK_SHOWN;
break;
+ case SyncPromoUI::SOURCE_BOOKMARK_BUBBLE:
+ uma = UMA_BOOKMARK_BUBBLE_SHOWN;
+ break;
case SyncPromoUI::SOURCE_UNKNOWN:
uma = UMA_UNKNOWN_SHOWN;
break;
@@ -74,7 +79,7 @@ void RecordUserShownPromo(content::WebUI* web_ui) {
// If this assert hits, then the SyncPromoUI::Source enum has changed and
// the UMA enum above, this switch statement and histograms.xml all need
// to be updated to reflect that.
- COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 8,
+ COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 9,
kSourceEnumHasChangedButNotThisSwitchStatement);
NOTREACHED();
break;
@@ -111,12 +116,15 @@ void RecordUserSignedIn(content::WebUI* web_ui) {
case SyncPromoUI::SOURCE_APPS_PAGE_LINK:
uma = UMA_APPS_PAGE_LINK_SIGNED_IN;
break;
+ case SyncPromoUI::SOURCE_BOOKMARK_BUBBLE:
+ uma = UMA_BOOKMARK_BUBBLE_SIGNED_IN;
+ break;
case SyncPromoUI::SOURCE_UNKNOWN:
uma = UMA_UNKNOWN_SIGNED_IN;
break;
default:
// This switch statement needs to be updated when the enum Source changes.
- COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 8,
+ COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 9,
kSourceEnumHasChangedButNotThisSwitchStatement);
NOTREACHED();
break;
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698