Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8501)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc

Issue 18603006: Bookmark sync promo for Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test for CrOS Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0825958fd8da4b1058e4820c8572900ee0b6c0c0
--- /dev/null
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc
@@ -0,0 +1,110 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
+
+#include <string>
+
+#include "base/command_line.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/bookmarks/bookmark_model_factory.h"
+#include "chrome/browser/bookmarks/bookmark_utils.h"
+#include "chrome/browser/signin/fake_signin_manager.h"
+#include "chrome/browser/signin/signin_manager.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/ui/bookmarks/bookmark_bubble_delegate.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/test/base/browser_with_test_window_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+
+namespace {
+const char kTestBookmarkURL[] = "http://www.google.com";
+} // namespace
+
+class BookmarkBubbleViewTest : public BrowserWithTestWindowTest {
+ public:
+ BookmarkBubbleViewTest() {}
+
+ // testing::Test:
+ virtual void SetUp() OVERRIDE {
+ BrowserWithTestWindowTest::SetUp();
+
+ CommandLine* command_line = CommandLine::ForCurrentProcess();
+ command_line->AppendSwitch(switches::kEnableBookmarkSyncPromo);
+
+ profile()->CreateBookmarkModel(true);
+ ui_test_utils::WaitForBookmarkModelToLoad(profile());
+
+ bookmark_utils::AddIfNotBookmarked(
+ BookmarkModelFactory::GetForProfile(profile()),
+ GURL(kTestBookmarkURL),
+ string16());
+ }
+
+ virtual void TearDown() OVERRIDE {
+ // Make sure the bubble is destroyed before the profile to avoid a crash.
+ bubble_.reset();
+
+ BrowserWithTestWindowTest::TearDown();
+ }
+
+ protected:
+ // Creates a bookmark bubble view.
+ void CreateBubbleView() {
+ scoped_ptr<BookmarkBubbleDelegate> delegate;
+ bubble_.reset(new BookmarkBubbleView(NULL,
+ NULL,
+ delegate.Pass(),
+ profile(),
+ GURL(kTestBookmarkURL),
+ true));
+ }
+
+ void CreateSigninManager(const std::string& username) {
+ SigninManagerBase* signin_manager =
+ static_cast<SigninManagerBase*>(
+ SigninManagerFactory::GetInstance()->SetTestingFactoryAndUse(
+ profile(),
+ &BookmarkBubbleViewTest::BuildFakeSignInManager));
+ signin_manager->Initialize(profile(), NULL);
+
+ if (!username.empty()) {
+ ASSERT_TRUE(signin_manager);
+ signin_manager->SetAuthenticatedUsername(username);
+ }
+ }
+
+ scoped_ptr<BookmarkBubbleView> bubble_;
+
+ private:
+ static BrowserContextKeyedService* BuildFakeSignInManager(
+ content::BrowserContext* profile) {
+#if defined(OS_CHROMEOS)
+ return new FakeSigninManagerBase();
+#else // !defined(OS_CHROMEOS)
+ return new FakeSigninManager(static_cast<Profile*>(profile));
+#endif
+ }
+
+ DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleViewTest);
+};
+
+// Verifies that the sync promo is not displayed for a signed in user.
+TEST_F(BookmarkBubbleViewTest, SyncPromoSignedIn) {
+ CreateSigninManager("fake_username");
+ CreateBubbleView();
+ bubble_->Init();
+ EXPECT_FALSE(bubble_->sync_promo_view_);
+}
+
+// Verifies that the sync promo is displayed for a user that is not signed in.
+TEST_F(BookmarkBubbleViewTest, SyncPromoNotSignedIn) {
+ CreateBubbleView();
+ bubble_->Init();
+#if defined(OS_CHROMEOS)
+ EXPECT_FALSE(bubble_->sync_promo_view_);
+#else // !defined(OS_CHROMEOS)
+ EXPECT_TRUE(bubble_->sync_promo_view_);
+#endif
+}

Powered by Google App Engine
This is Rietveld 408576698