Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2679)

Unified Diff: chrome/browser/ui/sync/sync_promo_ui.cc

Issue 18603006: Bookmark sync promo for Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test for CrOS Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/sync/sync_promo_ui.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/sync_promo_ui.cc
diff --git a/chrome/browser/ui/sync/sync_promo_ui.cc b/chrome/browser/ui/sync/sync_promo_ui.cc
index 591f4e2f32475fe46e29bb08f62a9528dc95d670..1c4bf7e3ccb8079594f4f761d8ed3d2daca18984 100644
--- a/chrome/browser/ui/sync/sync_promo_ui.cc
+++ b/chrome/browser/ui/sync/sync_promo_ui.cc
@@ -97,10 +97,6 @@ bool SyncPromoUI::ShouldShowSyncPromo(Profile* profile) {
if (net::NetworkChangeNotifier::IsOffline())
return false;
- // Don't show if the profile is an incognito.
- if (profile->IsOffTheRecord())
- return false;
-
// Don't show for managed profiles.
if (profile->GetPrefs()->GetBoolean(prefs::kProfileIsManaged))
return false;
@@ -143,6 +139,10 @@ bool SyncPromoUI::ShouldShowSyncPromoAtStartup(Profile* profile,
bool is_new_profile) {
DCHECK(profile);
+ // Don't show if the profile is an incognito.
+ if (profile->IsOffTheRecord())
+ return false;
+
if (!ShouldShowSyncPromo(profile))
return false;
« no previous file with comments | « chrome/browser/ui/sync/sync_promo_ui.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698