Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 18603006: Bookmark sync promo for Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test for CrOS Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/sync/one_click_signin_helper.h" 5 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <functional> 8 #include <functional>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 one_click_signin::HISTOGRAM_MAX); 175 one_click_signin::HISTOGRAM_MAX);
176 break; 176 break;
177 case SyncPromoUI::SOURCE_APP_LAUNCHER: 177 case SyncPromoUI::SOURCE_APP_LAUNCHER:
178 UMA_HISTOGRAM_ENUMERATION("Signin.AppLauncherActions", action, 178 UMA_HISTOGRAM_ENUMERATION("Signin.AppLauncherActions", action,
179 one_click_signin::HISTOGRAM_MAX); 179 one_click_signin::HISTOGRAM_MAX);
180 break; 180 break;
181 case SyncPromoUI::SOURCE_APPS_PAGE_LINK: 181 case SyncPromoUI::SOURCE_APPS_PAGE_LINK:
182 UMA_HISTOGRAM_ENUMERATION("Signin.AppsPageLinkActions", action, 182 UMA_HISTOGRAM_ENUMERATION("Signin.AppsPageLinkActions", action,
183 one_click_signin::HISTOGRAM_MAX); 183 one_click_signin::HISTOGRAM_MAX);
184 break; 184 break;
185 case SyncPromoUI::SOURCE_BOOKMARK_BUBBLE:
186 UMA_HISTOGRAM_ENUMERATION("Signin.BookmarkBubbleActions", action,
187 one_click_signin::HISTOGRAM_MAX);
188 break;
185 default: 189 default:
186 NOTREACHED() << "Invalid Source"; 190 // This switch statement needs to be updated when the enum Source changes.
191 COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 9,
192 kSourceEnumHasChangedButNotThisSwitchStatement);
193 NOTREACHED();
187 return; 194 return;
188 } 195 }
189 UMA_HISTOGRAM_ENUMERATION("Signin.AllAccessPointActions", action, 196 UMA_HISTOGRAM_ENUMERATION("Signin.AllAccessPointActions", action,
190 one_click_signin::HISTOGRAM_MAX); 197 one_click_signin::HISTOGRAM_MAX);
191 } 198 }
192 199
193 void LogOneClickHistogramValue(int action) { 200 void LogOneClickHistogramValue(int action) {
194 UMA_HISTOGRAM_ENUMERATION("Signin.OneClickActions", action, 201 UMA_HISTOGRAM_ENUMERATION("Signin.OneClickActions", action,
195 one_click_signin::HISTOGRAM_MAX); 202 one_click_signin::HISTOGRAM_MAX);
196 UMA_HISTOGRAM_ENUMERATION("Signin.AllAccessPointActions", action, 203 UMA_HISTOGRAM_ENUMERATION("Signin.AllAccessPointActions", action,
(...skipping 1116 matching lines...) Expand 10 before | Expand all | Expand 10 after
1313 content::Referrer(), 1320 content::Referrer(),
1314 content::PAGE_TRANSITION_AUTO_TOPLEVEL, 1321 content::PAGE_TRANSITION_AUTO_TOPLEVEL,
1315 std::string()); 1322 std::string());
1316 } 1323 }
1317 } 1324 }
1318 1325
1319 // Clear the redirect URL. 1326 // Clear the redirect URL.
1320 redirect_url_ = GURL(); 1327 redirect_url_ = GURL();
1321 sync_service->RemoveObserver(this); 1328 sync_service->RemoveObserver(this);
1322 } 1329 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc ('k') | chrome/browser/ui/sync/sync_promo_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698