Avoid GpuPreferences exposed in content public gpu interface

Avoid GpuPreferences exposed in content public gpu interface

Store GpuChildThread in TLS pointer and then GpuVideoDecodeAcceleratorFactory
can query GpuPreferences from GpuChildThread internally from aspect of
content/.

BUG=b/27687678
TEST=video playback as usual

Committed: https://crrev.com/7a526cd7c6985df2639f86f43d032a04587dd26e
Cr-Commit-Position: refs/heads/master@{#386121}

[kcwu, 2016-04-06 11:56:05]

kcwu@chromium.org changed reviewers:
+ jam@chromium.org, owenlin@chromium.org, posciak@chromium.org,
wuchengli@chromium.org

[kcwu, 2016-04-06 11:56:06]

John,

Could you please take a look? I removed GpuPreferences from VDA factory public
interface as your suggestion.

However, I am not sure how to handle the dependency problem. That is,
content/common/gpu/media/gpu_video_decode_accelerator_factory_impl.cc needs to
include content/gpu/gpu_child_thread.h

Thanks

[jam, 2016-04-06 16:22:00]

https://codereview.chromium.org/1859403002/diff/1/content/common/gpu/media/DEPS
File content/common/gpu/media/DEPS (right):

https://codereview.chromium.org/1859403002/diff/1/content/common/gpu/media/DE...
content/common/gpu/media/DEPS:2: "+content/gpu/gpu_child_thread.h",
this isn't allowed.

per the comment in the other change, GpuVideoDecodeAcceleratorFactory::CreateVDA
should be the one calling content/gpu/gpu_child_thread to get the gpu prefs

[kcwu, 2016-04-06 17:44:36]

https://codereview.chromium.org/1859403002/diff/1/content/common/gpu/media/DEPS
File content/common/gpu/media/DEPS (right):

https://codereview.chromium.org/1859403002/diff/1/content/common/gpu/media/DE...
content/common/gpu/media/DEPS:2: "+content/gpu/gpu_child_thread.h",
On 2016/04/06 16:22:00, jam wrote:
> this isn't allowed.
> 
> per the comment in the other change,
GpuVideoDecodeAcceleratorFactory::CreateVDA
> should be the one calling content/gpu/gpu_child_thread to get the gpu prefs

Done.

[kcwu, 2016-04-07 00:29:16]

Please take another look. Thanks.

[Owen Lin, 2016-04-08 01:31:57]

lgtm % nit

https://codereview.chromium.org/1859403002/diff/1/content/gpu/gpu_child_thread.h
File content/gpu/gpu_child_thread.h (right):

https://codereview.chromium.org/1859403002/diff/1/content/gpu/gpu_child_threa...
content/gpu/gpu_child_thread.h:59: static GpuChildThread* current();
please document it.

[kcwu, 2016-04-08 03:21:36]

https://codereview.chromium.org/1859403002/diff/1/content/gpu/gpu_child_thread.h
File content/gpu/gpu_child_thread.h (right):

https://codereview.chromium.org/1859403002/diff/1/content/gpu/gpu_child_threa...
content/gpu/gpu_child_thread.h:59: static GpuChildThread* current();
On 2016/04/08 01:31:57, Owen Lin wrote:
> please document it.

Done.

[jam, 2016-04-08 16:16:25]

lgtm

https://codereview.chromium.org/1859403002/diff/40001/content/public/gpu/gpu_...
File content/public/gpu/gpu_video_decode_accelerator_factory.cc (right):

https://codereview.chromium.org/1859403002/diff/40001/content/public/gpu/gpu_...
content/public/gpu/gpu_video_decode_accelerator_factory.cc:6: #include
"content/gpu/gpu_child_thread.h"
nit: add blank line before

[kcwu, 2016-04-08 16:39:45]

https://codereview.chromium.org/1859403002/diff/40001/content/public/gpu/gpu_...
File content/public/gpu/gpu_video_decode_accelerator_factory.cc (right):

https://codereview.chromium.org/1859403002/diff/40001/content/public/gpu/gpu_...
content/public/gpu/gpu_video_decode_accelerator_factory.cc:6: #include
"content/gpu/gpu_child_thread.h"
On 2016/04/08 16:16:25, jam wrote:
> nit: add blank line before

Done.
Move the corresponding header of this file to first.

[kcwu, 2016-04-08 16:40:02]

The CQ bit was checked by kcwu@chromium.org

[kcwu, 2016-04-08 16:40:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
owenlin@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1859403002/#ps60001
(title: "address jam's comments")

[commit-bot: I haz the power, 2016-04-08 16:40:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859403002/60001

[commit-bot: I haz the power, 2016-04-08 17:43:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-08 17:45:03]

Description was changed from

==========
Avoid GpuPreferences exposed in content public gpu interface

Store GpuChildThread in TLS pointer and then GpuVideoDecodeAcceleratorFactory
can query GpuPreferences from GpuChildThread internally from aspect of
content/.

BUG=b/27687678
TEST=video playback as usual
==========

to

==========
Avoid GpuPreferences exposed in content public gpu interface

Store GpuChildThread in TLS pointer and then GpuVideoDecodeAcceleratorFactory
can query GpuPreferences from GpuChildThread internally from aspect of
content/.

BUG=b/27687678
TEST=video playback as usual

Committed: https://crrev.com/7a526cd7c6985df2639f86f43d032a04587dd26e
Cr-Commit-Position: refs/heads/master@{#386121}
==========

[commit-bot: I haz the power, 2016-04-08 17:45:04]

Patchset 4 (id:??) landed as
https://crrev.com/7a526cd7c6985df2639f86f43d032a04587dd26e
Cr-Commit-Position: refs/heads/master@{#386121}