Issue 18594002: Don't use strtod_l in Mesa on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18594002: Don't use strtod_l in Mesa on Android (Closed)

Created:
7 years, 5 months ago by Myles C. Maxfield (Amazon.com)

Modified:
7 years, 5 months ago

Reviewers:
marcheu, Stephen White, Ken Russell (switch to Gerrit)

CC:
chromium-reviews, David Roche

Base URL:
https://src.chromium.org/chrome/trunk/deps/third_party/mesa/

Visibility:
Public.

More Reviews

Description

Don't use strtod_l in Mesa on Android Android includes a fix to asm/posix_types.h inside /ndk/toolchains/x86-4.7/prebuilt/linux-x86_64/lib/gcc/ i686-linux-android/4.7/include-fixed/asm/posix_types.h. That file #include_next's the real asm/posix_types.h, but then fixes (redefines) the __FD_ZERO macro. However, it also #includes features.h, which unconditionally defines _GNU_SOURCE. src/glsl/strtod.c assumes that if the _GNU_SOURCE macro is defined, that it can use locale_t, which isn't available on Android.

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/glsl/strtod.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mymax@amazon.com/18594002/1

7 years, 5 months ago (2013-07-04 02:30:01 UTC) #3

Message was sent while issue was closed.

Change committed as 210110

Expand Messages | Collapse Messages