Source/core/inspector/InspectorDebuggerAgent.cpp - Issue 18580011: DevTools: Disable sourceUrl and SourceMappingUrl deprecation warnings for a few releases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 18580011: DevTools: Disable sourceUrl and SourceMappingUrl deprecation warnings for a few releases. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/styles/stylesheet-source-url-comment-expected.txt ('k') | Source/core/inspector/InspectorPageAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDebuggerAgent.cpp

diff --git a/Source/core/inspector/InspectorDebuggerAgent.cpp b/Source/core/inspector/InspectorDebuggerAgent.cpp

index ad31830f2b6d06ffaa5dee76ed81a4c5a0dcb5ab..b3e2640ba86c553cea461d73e7dbed6ff232c356 100644

--- a/Source/core/inspector/InspectorDebuggerAgent.cpp

+++ b/Source/core/inspector/InspectorDebuggerAgent.cpp

@@ -666,8 +666,7 @@ String InspectorDebuggerAgent::sourceMapURLForScript(const Script& script)

bool deprecated;

String sourceMapURL = ContentSearchUtils::findSourceMapURL(script.source, ContentSearchUtils::JavaScriptMagicComment, &deprecated);

if (!sourceMapURL.isEmpty()) {

- if (deprecated)

- addConsoleMessage(NetworkMessageSource, WarningMessageLevel, "\"//@ sourceMappingURL=\" source mapping URL declaration is deprecated, \"//# sourceMappingURL=\" declaration should be used instead.", script.url);

+ // FIXME: add deprecated console message here.

return sourceMapURL;

}

@@ -692,8 +691,7 @@ void InspectorDebuggerAgent::didParseSource(const String& scriptId, const Script

if (!script.startLine && !script.startColumn) {

bool deprecated;

sourceURL = ContentSearchUtils::findSourceURL(script.source, ContentSearchUtils::JavaScriptMagicComment, &deprecated);

- if (deprecated)

- addConsoleMessage(NetworkMessageSource, WarningMessageLevel, "\"//@ sourceURL=\" source URL declaration is deprecated, \"//# sourceURL=\" declaration should be used instead.", script.url);

+ // FIXME: add deprecated console message here.

}

bool hasSourceURL = !sourceURL.isEmpty();

String scriptURL = hasSourceURL ? sourceURL : script.url;