Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: third_party/WebKit/Source/platform/graphics/BitmapImage.h

Issue 1857543002: Don't recreate SkImages for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review #4 fix. Thanks @pkasting. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/BitmapImage.h
diff --git a/third_party/WebKit/Source/platform/graphics/BitmapImage.h b/third_party/WebKit/Source/platform/graphics/BitmapImage.h
index 5275168eded9118afa9fd4963aab2e7e5878f221..0ff69096f3ea721e1958cf1792bc7df9ccd080e6 100644
--- a/third_party/WebKit/Source/platform/graphics/BitmapImage.h
+++ b/third_party/WebKit/Source/platform/graphics/BitmapImage.h
@@ -134,17 +134,10 @@ private:
// the values from successive calls as signed expressions.
int totalFrameBytes();
- // Called to invalidate cached data. When |destroyAll| is true, we wipe out
- // the entire frame buffer cache and tell the image source to destroy
- // everything; this is used when e.g. we want to free some room in the image
- // cache. If |destroyAll| is false, we delete frames except the current
- // frame; this is used while animating large images to keep memory footprint
- // low; the decoder should preserve the current frame and may preserve some
- // other frames to avoid redecoding the whole image on every frame.
- void destroyDecodedData(bool destroyAll) override;
-
- // If the image is large enough, calls destroyDecodedData().
- void destroyDecodedDataIfNecessary();
+ // Called to wipe out the entire frame buffer cache and tell the image
+ // source to destroy everything; this is used when e.g. we want to free
+ // some room in the image cache.
+ void destroyDecodedData() override;
// Notifies observers that the memory footprint has changed.
void notifyMemoryChanged(int delta);

Powered by Google App Engine
This is Rietveld 408576698