Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: content/browser/device_orientation/device_motion_provider.h

Issue 18572014: Implement Android shared memory data fetcher for Device Motion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderer-sync-12June-tryASYNC-2-bis-tryRebase-6
Patch Set: rebased Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/device_orientation/device_motion_provider.h
diff --git a/content/browser/device_orientation/device_motion_provider.h b/content/browser/device_orientation/device_motion_provider.h
index 90a3e72934dd847c5a4eecf33c259e003953eb8b..a5b94c923baea9918a08bd77bf43013fda6cc234 100644
--- a/content/browser/device_orientation/device_motion_provider.h
+++ b/content/browser/device_orientation/device_motion_provider.h
@@ -11,8 +11,7 @@
#include "content/common/device_motion_hardware_buffer.h"
namespace content {
-
-// TODO(timvolodine): Add data fetcher to this class.
+class DataFetcherSharedMemory;
class CONTENT_EXPORT DeviceMotionProvider {
public:
@@ -34,8 +33,7 @@ class CONTENT_EXPORT DeviceMotionProvider {
DeviceMotionHardwareBuffer* SharedMemoryAsHardwareBuffer();
- // TODO(timvolodine): add member variable,
- // scoped_ptr<DataFetcherSharedMemory> data_fetcher_;
+ scoped_ptr<DataFetcherSharedMemory> data_fetcher_;
bool is_started_;

Powered by Google App Engine
This is Rietveld 408576698