content/browser/device_orientation/device_motion_provider.h - Issue 18572014: Implement Android shared memory data fetcher for Device Motion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_orientation/device_motion_provider.h

Issue 18572014: Implement Android shared memory data fetcher for Device Motion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderer-sync-12June-tryASYNC-2-bis-tryRebase-6

Patch Set: fixed comments, added proper singleton implementation and shutdown. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/device_orientation/data_fetcher_impl_android.cc ('K') | « content/browser/device_orientation/data_fetcher_shared_memory_default.cc ('k') | content/browser/device_orientation/device_motion_provider.cc » ('j') | content/browser/device_orientation/provider_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_orientation/device_motion_provider.h

diff --git a/content/browser/device_orientation/device_motion_provider.h b/content/browser/device_orientation/device_motion_provider.h

index 30cdde45b4a47b581560b33ec517e67dd10aef38..7c3bcf6162b6064623c40b2ebe5d09bc7f8e0c07 100644

--- a/content/browser/device_orientation/device_motion_provider.h

+++ b/content/browser/device_orientation/device_motion_provider.h

@@ -11,8 +11,7 @@

#include "content/common/device_motion_hardware_buffer.h"

namespace content {

-// TODO(timvolodine) Implement this class properly.

+class DataFetcherSharedMemory;

class CONTENT_EXPORT DeviceMotionProvider {

public:

@@ -30,15 +29,8 @@ class CONTENT_EXPORT DeviceMotionProvider {

void StopFetchingDeviceMotionData();

private:

- static DeviceMotionProvider* instance_;

base::SharedMemory device_motion_shared_memory_;

DeviceMotionHardwareBuffer* SharedMemoryAsHardwareBuffer();

- // FIXME: add member variable,

- // scoped_ptr<DataFetcherSharedMemory> data_fetcher_;

bool is_started_;

DISALLOW_COPY_AND_ASSIGN(DeviceMotionProvider);