content/browser/device_orientation/accelerometer_mac.cc - Issue 18572014: Implement Android shared memory data fetcher for Device Motion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_orientation/accelerometer_mac.cc

Issue 18572014: Implement Android shared memory data fetcher for Device Motion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderer-sync-12June-tryASYNC-2-bis-tryRebase-6

Patch Set: fixed comments, added proper singleton implementation and shutdown. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_main_loop.cc ('K') | « content/browser/device_orientation/accelerometer_mac.h ('k') | content/browser/device_orientation/data_fetcher_impl_android.h » ('j') | content/browser/device_orientation/data_fetcher_impl_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_orientation/accelerometer_mac.cc

diff --git a/content/browser/device_orientation/accelerometer_mac.cc b/content/browser/device_orientation/accelerometer_mac.cc

index 04c5d71b65c213c01b5400122be7bc8dd921e17d..af2d946559558e10f52e4f87b42526a2f417da96 100644

--- a/content/browser/device_orientation/accelerometer_mac.cc

+++ b/content/browser/device_orientation/accelerometer_mac.cc

@@ -12,10 +12,15 @@

namespace content {

+AccelerometerMac* AccelerometerMac::instance() {

+ CR_DEFINE_STATIC_LOCAL(AccelerometerMac, s_data_fetcher, ());

+ return &s_data_fetcher;

// Create a AccelerometerMac object and return NULL if no valid sensor found.

DataFetcher* AccelerometerMac::Create() {

- scoped_ptr<AccelerometerMac> accelerometer(new AccelerometerMac);

- return accelerometer->Init() ? accelerometer.release() : NULL;

+ AccelerometerMac* accelerometer = AccelerometerMac::instance();

+ return accelerometer->Init() ? accelerometer : NULL;

}

AccelerometerMac::~AccelerometerMac() {