Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: content/browser/device_orientation/data_fetcher_impl_android.h

Issue 18572014: Implement Android shared memory data fetcher for Device Motion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderer-sync-12June-tryASYNC-2-bis-tryRebase-6
Patch Set: fixed comments, added proper singleton implementation and shutdown. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVICE_ORIENTATION_DATA_FETCHER_IMPL_ANDROID_H_ 5 #ifndef CHROME_BROWSER_DEVICE_ORIENTATION_DATA_FETCHER_IMPL_ANDROID_H_
6 #define CHROME_BROWSER_DEVICE_ORIENTATION_DATA_FETCHER_IMPL_ANDROID_H_ 6 #define CHROME_BROWSER_DEVICE_ORIENTATION_DATA_FETCHER_IMPL_ANDROID_H_
7 7
8 #include "base/android/scoped_java_ref.h" 8 #include "base/android/scoped_java_ref.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/synchronization/lock.h" 10 #include "base/synchronization/lock.h"
11 #include "content/browser/device_orientation/data_fetcher.h" 11 #include "content/browser/device_orientation/data_fetcher.h"
12 #include "content/browser/device_orientation/device_data.h" 12 #include "content/browser/device_orientation/device_data.h"
13 #include "content/common/device_motion_hardware_buffer.h"
14
15 template<typename T> struct DefaultSingletonTraits;
bulach 2013/07/10 16:59:41 nit: LeakySingletonTraits
timvolodine 2013/07/11 14:31:34 apparently this needs to be DefaultSingletonTraits
13 16
14 namespace content { 17 namespace content {
15
16 class Orientation; 18 class Orientation;
17 19
18 // Android implementation of DeviceOrientation API. 20 // Android implementation of DeviceOrientation API.
19 21
20 // Android's SensorManager has a push API, whereas Chrome wants to pull data. 22 // Android's SensorManager has a push API, whereas Chrome wants to pull data.
21 // To fit them together, we store incoming sensor events in a 1-element buffer. 23 // To fit them together, we store incoming sensor events in a 1-element buffer.
22 // SensorManager calls SetOrientation() which pushes a new value (discarding the 24 // SensorManager calls SetOrientation() which pushes a new value (discarding the
23 // previous value if any). Chrome calls GetDeviceData() which reads the most 25 // previous value if any). Chrome calls GetDeviceData() which reads the most
24 // recent value. Repeated calls to GetDeviceData() will return the same value. 26 // recent value. Repeated calls to GetDeviceData() will return the same value.
25 27
28 // TODO(timvolodine): Move this class implementation to
29 // data_fetcher_shared_memory_android.cc, once Device Orientation switches to
30 // shared memory implementation.
26 class DataFetcherImplAndroid : public DataFetcher { 31 class DataFetcherImplAndroid : public DataFetcher {
27 public: 32 public:
28 // Must be called at startup, before Create(). 33 // Must be called at startup, before Create().
29 static void Init(JNIEnv* env); 34 static void Register(JNIEnv* env);
30 35
31 // Factory function. We'll listen for events for the lifetime of this object. 36 // Factory function. We'll listen for events for the lifetime of this object.
32 // Returns NULL on error. 37 // Returns NULL on error.
33 static DataFetcher* Create(); 38 static DataFetcher* Create();
34 39
35 virtual ~DataFetcherImplAndroid(); 40 // Needs to be thread-safe, because accessed from a thread in provider_impl.cc
bulach 2013/07/10 16:59:41 nit: s/a thread/different threads/
timvolodine 2013/07/11 14:31:34 Done.
41 // and device_motion_provider.cc.
42 static DataFetcherImplAndroid* GetInstance();
36 43
37 // Called from Java via JNI. 44 // Called from Java via JNI.
38 void GotOrientation(JNIEnv*, jobject, 45 void GotOrientation(JNIEnv*, jobject,
39 double alpha, double beta, double gamma); 46 double alpha, double beta, double gamma);
40 void GotAcceleration(JNIEnv*, jobject, 47 void GotAcceleration(JNIEnv*, jobject,
41 double x, double y, double z); 48 double x, double y, double z);
42 void GotAccelerationIncludingGravity(JNIEnv*, jobject, 49 void GotAccelerationIncludingGravity(JNIEnv*, jobject,
43 double x, double y, double z); 50 double x, double y, double z);
44 void GotRotationRate(JNIEnv*, jobject, 51 void GotRotationRate(JNIEnv*, jobject,
45 double alpha, double beta, double gamma); 52 double alpha, double beta, double gamma);
46 53
47 // Implementation of DataFetcher. 54 // Implementation of DataFetcher.
48 virtual const DeviceData* GetDeviceData(DeviceData::Type type) OVERRIDE; 55 virtual const DeviceData* GetDeviceData(DeviceData::Type type) OVERRIDE;
49 56
50 private:
51 DataFetcherImplAndroid();
52 const Orientation* GetOrientation();
53
54 // Wrappers for JNI methods. 57 // Wrappers for JNI methods.
55 // TODO(timvolodine): move the DeviceData::Type enum to the service class 58 // TODO(timvolodine): move the DeviceData::Type enum to the service class
56 // once it is implemented. 59 // once it is implemented.
57 bool Start(DeviceData::Type event_type, int rate_in_milliseconds); 60 virtual bool Start(DeviceData::Type event_type, int rate_in_milliseconds);
58 void Stop(DeviceData::Type event_type); 61 virtual void Stop(DeviceData::Type event_type);
62
63 // Shared memory related methods.
64 virtual bool NeedsPolling();
65 virtual bool FetchDeviceMotionDataIntoBuffer();
66 virtual bool StartFetchingDeviceMotionData(
67 DeviceMotionHardwareBuffer* buffer);
68 virtual void StopFetchingDeviceMotionData();
69
70 protected:
71 DataFetcherImplAndroid();
72 virtual ~DataFetcherImplAndroid();
73
74 const Orientation* GetOrientation();
59 75
60 virtual int GetNumberActiveDeviceMotionSensors(); 76 virtual int GetNumberActiveDeviceMotionSensors();
77 void CheckBufferReadyToRead();
78 void SetBufferReadyStatus(bool ready);
79 void ClearInternalBuffers();
61 80
81 private:
82 friend struct DefaultSingletonTraits<DataFetcherImplAndroid>;
83
84 enum {
85 RECEIVED_MOTION_DATA_ACCELERATION = 0,
86 RECEIVED_MOTION_DATA_ACCELERATION_INCL_GRAVITY = 1,
87 RECEIVED_MOTION_DATA_ROTATION_RATE = 2,
88 RECEIVED_MOTION_DATA_MAX = 3,
89 };
62 // Value returned by GetDeviceData. 90 // Value returned by GetDeviceData.
63 scoped_refptr<Orientation> current_orientation_; 91 scoped_refptr<Orientation> current_orientation_;
64 92
65 // 1-element buffer, written by GotOrientation, read by GetDeviceData. 93 // 1-element buffer, written by GotOrientation, read by GetDeviceData.
66 base::Lock next_orientation_lock_; 94 base::Lock next_orientation_lock_;
67 scoped_refptr<Orientation> next_orientation_; 95 scoped_refptr<Orientation> next_orientation_;
68 96
69 // The Java provider of orientation info. 97 // The Java provider of orientation info.
70 base::android::ScopedJavaGlobalRef<jobject> device_orientation_; 98 base::android::ScopedJavaGlobalRef<jobject> device_orientation_;
99 int number_active_device_motion_sensors_;
100 int received_motion_data_[RECEIVED_MOTION_DATA_MAX];
101 DeviceMotionHardwareBuffer* device_motion_buffer_;
102 bool is_buffer_ready_;
71 103
72 DISALLOW_COPY_AND_ASSIGN(DataFetcherImplAndroid); 104 DISALLOW_COPY_AND_ASSIGN(DataFetcherImplAndroid);
73 }; 105 };
74 106
75 } // namespace content 107 } // namespace content
76 108
77 #endif // CHROME_BROWSER_DEVICE_ORIENTATION_DATA_FETCHER_IMPL_ANDROID_H_ 109 #endif // CHROME_BROWSER_DEVICE_ORIENTATION_DATA_FETCHER_IMPL_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698