Issue 18570002: Can't #define assert() before including assert.h on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18570002: Can't #define assert() before including assert.h on Android (Closed)

Created:
7 years, 5 months ago by Myles C. Maxfield (Amazon.com)

Modified:
7 years, 5 months ago

Reviewers:
Ken Russell (switch to Gerrit), Stephen White, marcheu

CC:
chromium-reviews

Base URL:
https://src.chromium.org/chrome/trunk/deps/third_party/mesa/

Visibility:
Public.

More Reviews

Description

Can't #define assert() before including assert.h on Android Android's assert.h #errors if assert() has already been defined. At least one file in mesa includes u_debug.h (which #defines assert()) before including assert.h. This makes sure that assert.h always gets included at the beginning of u_debug.h.

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/gallium/auxiliary/util/u_debug.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mymax@amazon.com/18570002/1

7 years, 5 months ago (2013-07-04 02:28:21 UTC) #3

Message was sent while issue was closed.

Change committed as 210108

Expand Messages | Collapse Messages