Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 18569006: Chromium Android layout test bots should be using "android" as the platform. (Closed)

Created:
7 years, 5 months ago by Peter Beverloo
Modified:
7 years, 5 months ago
Reviewers:
Yaron, abarth-chromium
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Chromium Android layout test bots should be using "android" as the platform. The platform has been renamed from "chromium-android" to "android" in the past week, which was causing the layout test runner to fail with a fatal error. Correct this. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Peter Beverloo
Yaron, mind having a look? This is breaking the layout test bot because of an ...
7 years, 5 months ago (2013-07-12 17:30:52 UTC) #1
Peter Beverloo
Log available here: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28GalaxyNexus%29/builds/11938/steps/webkit_tests/logs/stdio
7 years, 5 months ago (2013-07-12 17:31:12 UTC) #2
abarth-chromium
LGTM (but I'm not an owner)
7 years, 5 months ago (2013-07-12 17:34:44 UTC) #3
Yaron
lgtm
7 years, 5 months ago (2013-07-12 18:32:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/18569006/1
7 years, 5 months ago (2013-07-15 11:18:05 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-15 14:55:20 UTC) #6
Message was sent while issue was closed.
Change committed as 211640

Powered by Google App Engine
This is Rietveld 408576698