Disable default touch icons handling.

Disable default touch icons handling.

When no link rel=apple-touch-icon is present on a page, mobile chrome currently
sends requests for apple-touch-icon.png and apple-touch-icon-precomposed.png. A
very large majority of those requests fail with a 404. To save battery and data
plan, this CL disable those requests. Clients should use link rel=icon instead.

We can't turn of TOUCH_ICON_LOADING because we still want to support link
rel=apple-touch-icon

 Resubmitted after removing the test checking for this behavior in chromium: https://codereview.chromium.org/18903004/

R=thakis@chromium.org
BUG=258963, 259681
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154413

[qsr, 2013-07-11 07:39:16]

This is a reland as is after fixing upstream tests.

[Nico, 2013-07-11 16:05:30]

Can you link to the test fixes? (If they're linked on the bug, disregard.
On phone, didn't check)

Lgtm
On Jul 11, 2013 12:38 AM, <qsr@chromium.org> wrote:

> Reviewers: Nico,
>
> Description:
> Disable default touch icons handling.
>
> When no link rel=apple-touch-icon is present on a page, mobile chrome
> currently
> sends requests for apple-touch-icon.png and apple-touch-icon-precomposed.*
> *png. A
> very large majority of those requests fail with a 404. To save battery and
> data
> plan, this CL disable those requests. Clients should use link rel=icon
> instead.
>
> We can't turn of TOUCH_ICON_LOADING because we still want to support link
> rel=apple-touch-icon
>
> R=thakis@chromium.org
> BUG=258963
>
> Please review this at
https://codereview.chromium.**org/18569004/<https://codereview.chromium.org/1...
>
> SVN Base:
https://chromium.googlesource.**com/chromium/blink.git@master<https://chromiu...
>
> Affected files:
>   M Source/core/loader/**IconController.cpp
>
>
> Index: Source/core/loader/**IconController.cpp
> diff --git a/Source/core/loader/**IconController.cpp b/Source/core/loader/
> **IconController.cpp
> index e687668974dc9cec90157d5153c6b4**1039918087..**
> b112bc4cabb8e1941a4f6e04ae4c77**71795cf016 100644
> --- a/Source/core/loader/**IconController.cpp
> +++ b/Source/core/loader/**IconController.cpp
> @@ -79,18 +79,8 @@ IconURLs IconController::urlsForTypes(**int
> iconTypesMask)
>          iconURLs.append(defaultURL(**Favicon));
>
>  #if ENABLE(TOUCH_ICON_LOADING)
> -    int missedIcons = 0;
> -    if (iconTypesMask & TouchPrecomposedIcon)
> -        missedIcons += appendToIconURLs(**TouchPrecomposedIcon,
> &iconURLs) ? 0:1;
> -
> -    if (iconTypesMask & TouchIcon)
> -      missedIcons += appendToIconURLs(TouchIcon, &iconURLs) ? 0:1;
> -
> -    // Only return the default touch icons when the both were required
> and neither was gotten.
> -    if (missedIcons == 2) {
> -        iconURLs.append(defaultURL(**TouchPrecomposedIcon));
> -        iconURLs.append(defaultURL(**TouchIcon));
> -    }
> +    appendToIconURLs(**TouchPrecomposedIcon, &iconURLs);
> +    appendToIconURLs(TouchIcon, &iconURLs);
>  #endif
>
>      // Finally, append all remaining icons of this type.
> @@ -137,16 +127,6 @@ IconURL IconController::defaultURL(**IconType
> iconType)
>          url.setPath("/favicon.ico");
>          return IconURL::defaultIconURL(url, Favicon);
>      }
> -#if ENABLE(TOUCH_ICON_LOADING)
> -    if (iconType == TouchPrecomposedIcon) {
> -        url.setPath("/apple-touch-**icon-precomposed.png");
> -        return IconURL::defaultIconURL(url, TouchPrecomposedIcon);
> -    }
> -    if (iconType == TouchIcon) {
> -        url.setPath("/apple-touch-**icon.png");
> -        return IconURL::defaultIconURL(url, TouchIcon);
> -    }
> -#endif
>      return IconURL();
>  }
>
>
>
>

[commit-bot: I haz the power, 2013-07-17 14:20:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/18569004/1

[commit-bot: I haz the power, 2013-07-17 14:30:03]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-07-17 15:21:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/18569004/14001

[commit-bot: I haz the power, 2013-07-17 16:44:13]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-07-17 17:02:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/18569004/14001

[commit-bot: I haz the power, 2013-07-17 18:51:54]

Change committed as 154413