Web MIDI: add assign() and equals() to WebMIDIPermissionRequest

Web MIDI: add assign() and equals() to WebMIDIPermissionRequest

Since WebMIDIPermissionRequeset should be managed by embedder
until the permission decision is made, export assign() and
equals() methods. It makes it possible to handle them in a
container.

TEST=none
BUG=163795
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154188

[Takashi Toyoshima, 2013-07-12 09:42:32]

(CC: Chris)

Hi Adam,
Can you take a look this minor API update change?
I need to use assign() and equals() since embedder holds
WebMIDIPermissionRequest until an asynchronous operation is completed.
Objects are managed by IDMap in embedder side, and will be removed when the
operation is finished, or page navigation happens and it calls
cancelSysExPermissionRequest.

[abarth-chromium, 2013-07-12 23:00:34]

lgtm

https://codereview.chromium.org/18563008/diff/1/Source/web/WebMIDIPermissionR...
File Source/web/WebMIDIPermissionRequest.cpp (right):

https://codereview.chromium.org/18563008/diff/1/Source/web/WebMIDIPermissionR...
Source/web/WebMIDIPermissionRequest.cpp:60: return (m_private.get() ==
n.m_private.get());
No need for the outer (  )

https://codereview.chromium.org/18563008/diff/1/public/web/WebMIDIPermissionR...
File public/web/WebMIDIPermissionRequest.h (right):

https://codereview.chromium.org/18563008/diff/1/public/web/WebMIDIPermissionR...
public/web/WebMIDIPermissionRequest.h:58: WEBKIT_EXPORT bool equals(const
WebMIDIPermissionRequest&) const;
You might want to add an inline operator== to call equals.

[Takashi Toyoshima, 2013-07-14 08:33:29]

Thank you.

https://codereview.chromium.org/18563008/diff/1/Source/web/WebMIDIPermissionR...
File Source/web/WebMIDIPermissionRequest.cpp (right):

https://codereview.chromium.org/18563008/diff/1/Source/web/WebMIDIPermissionR...
Source/web/WebMIDIPermissionRequest.cpp:60: return (m_private.get() ==
n.m_private.get());
On 2013/07/12 23:00:34, abarth wrote:
> No need for the outer (  )

Done.

I also fixed similar nits here and there.

https://codereview.chromium.org/18563008/diff/1/public/web/WebMIDIPermissionR...
File public/web/WebMIDIPermissionRequest.h (right):

https://codereview.chromium.org/18563008/diff/1/public/web/WebMIDIPermissionR...
public/web/WebMIDIPermissionRequest.h:58: WEBKIT_EXPORT bool equals(const
WebMIDIPermissionRequest&) const;
I see. I added inline operator functions for == and != as other classes do.

[commit-bot: I haz the power, 2013-07-14 08:35:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/18563008/6001

[commit-bot: I haz the power, 2013-07-14 10:05:09]

Change committed as 154188