Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 1856273002: Change all FlakyTest import to use org.chromium.base.test.util.FlakyTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change @FlakyTest bug message Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index c55b9744c7cbba1d14b154a1fa2f61bfa909907b..970922e79de8f58719fff2d61bb1cb0d51b3fb9e 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -11,13 +11,13 @@ import android.content.ContextWrapper;
import android.os.ConditionVariable;
import android.os.Handler;
import android.os.Looper;
-import android.test.FlakyTest;
import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.PathUtils;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.FlakyTest;
import org.chromium.net.CronetEngine.UrlRequestInfo;
import org.chromium.net.TestUrlRequestCallback.ResponseStep;
import org.chromium.net.test.EmbeddedTestServer;
@@ -341,9 +341,8 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
@SuppressWarnings("deprecation")
- https://crbug.com/592444
*/
- @FlakyTest
+ @FlakyTest(message = "https://crbug.com/592444")
public void testRequestFinishedListenerFailedRequest() throws Exception {
String connectionRefusedUrl = "http://127.0.0.1:3";
mTestFramework = startCronetTestFramework();
@@ -552,9 +551,8 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
/*
@SmallTest
@Feature({"Cronet"})
- https://crbug.com/592444
*/
- @FlakyTest
+ @FlakyTest(message = "https://crbug.com/592444")
public void testShutdownAfterError() throws Exception {
mTestFramework = startCronetTestFramework();
TestUrlRequestCallback callback = new ShutdownTestUrlRequestCallback();

Powered by Google App Engine
This is Rietveld 408576698