chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java - Issue 1856273002: Change all FlakyTest import to use org.chromium.base.test.util.FlakyTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

Issue 1856273002: Change all FlakyTest import to use org.chromium.base.test.util.FlakyTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change @FlakyTest bug message Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/video/FullscreenVideoTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

index db276864572e9f8c77fa1fe45fae4991952e5d23..5a66461dbfd347c38264981851d416bc20034d6a 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

@@ -4,10 +4,10 @@

package org.chromium.chrome.browser.tabmodel;

-import android.test.FlakyTest;

import android.test.suitebuilder.annotation.MediumTest;

import org.chromium.base.ThreadUtils;

+import org.chromium.base.test.util.FlakyTest;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;

@@ -997,7 +997,7 @@ public class UndoTabModelTest extends ChromeTabbedActivityTestBase {

* @throws InterruptedException

@MediumTest

- @FlakyTest // crbug.com/592969

+ @FlakyTest(message = "crbug.com/592969")

public void testOutOfOrder2() throws InterruptedException {

TabModel model = getActivity().getTabModelSelector().getModel(false);

ChromeTabCreator tabCreator = getActivity().getTabCreator(false);