Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java

Issue 1856273002: Change all FlakyTest import to use org.chromium.base.test.util.FlakyTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change @FlakyTest bug message Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
index e1d1efd05440271d2ba8716d9f0e159aac293b37..70035714f455ef4159bd03d5bca4b599f4e19aa1 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
@@ -9,7 +9,6 @@ import android.net.Uri;
import android.os.Bundle;
import android.os.Environment;
import android.provider.Browser;
-import android.test.FlakyTest;
import android.test.suitebuilder.annotation.LargeTest;
import android.test.suitebuilder.annotation.MediumTest;
import android.text.TextUtils;
@@ -22,6 +21,7 @@ import org.chromium.base.BaseSwitches;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.FlakyTest;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.tab.EmptyTabObserver;
import org.chromium.chrome.browser.tab.Tab;
@@ -498,9 +498,8 @@ public class TabsOpenedFromExternalAppTest extends ChromeTabbedActivityTestBase
/**
* @LargeTest
* @Feature({"Navigation"})
- * Bug 6467101
*/
- @FlakyTest
+ @FlakyTest(message = "http://crbug.com/6467101")
gone 2016/04/08 00:16:17 This is a buganizer bug.
public void testNewTabWhenPageEdited() throws InterruptedException, TimeoutException {
startMainActivityFromLauncher();
@@ -546,9 +545,8 @@ public class TabsOpenedFromExternalAppTest extends ChromeTabbedActivityTestBase
/**
* Catches regressions for https://crbug.com/495877.
- * Flakiness reported in https://crbug.com/571030
*/
- @FlakyTest
+ @FlakyTest(message = "https://crbug.com/571030")
@MediumTest
@CommandLineFlags.Add(BaseSwitches.ENABLE_LOW_END_DEVICE_MODE)
public void testBackgroundSvelteTabIsSelectedAfterClosingExternalTab() throws Exception {

Powered by Google App Engine
This is Rietveld 408576698