Issue 18552004: Remove SkRasterClip::setPath(const SkPath&, const SkRasterClip&, bool).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18552004: Remove SkRasterClip::setPath(const SkPath&, const SkRasterClip&, bool). (Closed)

Created:
7 years, 5 months ago by f(malita)

Modified:
7 years, 5 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove SkRasterClip::setPath(const SkPath&, const SkRasterClip&, bool). The method is only used in SkCanvas::clipPathHelper() and only called when isRect() is true (which effectively disables the !isBW branch). Thus, we can promote the isBW branch to the caller and drop the rest of the method. R=reed@google.com Committed: http://code.google.com/p/skia/source/detail?r=9974

Patch Set 1 #

Patch Set 2 : Revert isBW() back to isRect(). #

Patch Set 3 : Added some comments. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -16 lines)			Patch
M	src/core/SkCanvas.cpp	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/core/SkRasterClip.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkRasterClip.cpp	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

f(malita)

Relaxing the conditional from currClip->isRect() to currClip->isBW() is triggering asserts: GM: drawing... complexclip2_path_bw [370 370] ...

7 years, 5 months ago (2013-07-03 14:55:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/18552004/13001

7 years, 5 months ago (2013-07-10 20:43:31 UTC) #5

Message was sent while issue was closed.

Change committed as 9974

Expand Messages | Collapse Messages