DevTools: Introduce Target class which holds connection & models

Source/devtools/front_end/InspectorBackend.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 20 matching lines @@
 /**
  * @constructor
  */
 function InspectorBackendClass()
 {
     this._connection = null;
     this._agentPrototypes = {};
     this._dispatcherPrototypes = {};
     this._initialized = false;
     this._enums = {};
+    this.initProtocolAgentsClass();
 }
 
 InspectorBackendClass.prototype = {
 
+    initProtocolAgentsClass: function() {

[vsevik, 2014/03/06 16:30:08]

{ on the next line.
This method should be private.

[sergeyv, 2014/03/06 16:45:37]

Done.

+
+        window.Protocol = {};
+
+        /**
+         * @constructor
+         * @param {!Object.<string, !Object>} agentsMap
+         */
+        window.Protocol.Agents = function(agentsMap) {
+            this._agentsMap = agentsMap;
+        };
+    },
+
+    /**
+     * @param {string} domain
+     */
+    _addProtocolAgentsMethodIfNeeded: function(domain)
+    {
+        if (this._agentPrototypes[domain])
+            return;
+
+        var upperCaseLength = 0;
+        while (upperCaseLength < domain.length && domain[upperCaseLength].toLowerCase() !== domain[upperCaseLength])
+            ++upperCaseLength;
+
+        var methodName = domain.substr(0, upperCaseLength).toLowerCase() + domain.slice(upperCaseLength) + "Agent";
+
+        /**
+         * @this {Protocol.Agents}
+         */
+        function agentGetter()
+        {
+            return this._agentsMap[domain];
+        }
+
+        window.Protocol.Agents.prototype[methodName] = agentGetter;
+    },
+
     /**
      * @return {!InspectorBackendClass.Connection}
      */
     connection: function()
     {
         if (!this._connection)
             throw "Main connection was not initialized";
         return this._connection;
     },
 
@@ skipping 37 matching lines @@
 
     /**
      * @param {string} method
      * @param {!Array.<!Object>} signature
      * @param {!Array.<string>} replyArgs
      * @param {boolean} hasErrorData
      */
     registerCommand: function(method, signature, replyArgs, hasErrorData)
     {
         var domainAndMethod = method.split(".");
+        this._addProtocolAgentsMethodIfNeeded(domainAndMethod[0]);

[vsevik, 2014/03/06 16:30:08]

You could move this call to _agentPrototype and get rid of IfNeeded suffix and
extra check.

[sergeyv, 2014/03/06 16:45:37]

Done.

         this._agentPrototype(domainAndMethod[0]).registerCommand(domainAndMethod[1], signature, replyArgs, hasErrorData);
         this._initialized = true;
     },
 
     /**
      * @param {string} type
      * @param {!Object} values
      */
     registerEnum: function(type, values)
     {
@@ skipping 219 matching lines @@
     /**
      * @param {string} domain
      * @return {!InspectorBackendClass.AgentPrototype}
      */
     agent: function(domain)
     {
         return this._agents[domain];
     },
 
     /**
+     * @return {!Object.<string, !Object>}
+     */
+    agentsMap: function()
+    {
+        return this._agents;
+    },
+
+    /**
      * @param {string} domain
      * @param {string} method
      * @param {?Object} params
      * @param {?function(*)} callback
      * @private
      */
     _wrapCallbackAndSendMessageObject: function(domain, method, params, callback)
     {
         var messageObject = {};
         messageObject.method = method;
@@ skipping 356 matching lines @@
     }
 
 }
 
 InspectorBackendClass.Options = {
     dumpInspectorTimeStats: false,
     dumpInspectorProtocolMessages: false
 }
 
 InspectorBackend = new InspectorBackendClass();