net/socket/ssl_client_socket_pool_unittest.cc - Issue 18546008: [SPDY] Use WeakPtr<SpdySession> everywhere but SpdySessionPool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_pool_unittest.cc

Issue 18546008: [SPDY] Use WeakPtr<SpdySession> everywhere but SpdySessionPool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test, other minor formatting/comment changes Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_pool_unittest.cc

diff --git a/net/socket/ssl_client_socket_pool_unittest.cc b/net/socket/ssl_client_socket_pool_unittest.cc

index 4652de8a868237247b12edc156d2b4cc7daa5d6b..d237528a28578b7e8ca1433717ab0cec83177761 100644

--- a/net/socket/ssl_client_socket_pool_unittest.cc

+++ b/net/socket/ssl_client_socket_pool_unittest.cc

@@ -759,7 +759,7 @@ TEST_F(SSLClientSocketPoolTest, IPPooling) {

socket_factory_.AddSSLSocketDataProvider(&ssl);

CreatePool(true /* tcp pool */, false, false);

- scoped_refptr<SpdySession> spdy_session =

+ base::WeakPtr<SpdySession> spdy_session =

CreateSecureSpdySession(session_, test_hosts[0].key, BoundNetLog());

EXPECT_TRUE(

@@ -812,7 +812,7 @@ void SSLClientSocketPoolTest::TestIPPoolingDisabled(

socket_factory_.AddSSLSocketDataProvider(ssl);

CreatePool(true /* tcp pool */, false, false);

- scoped_refptr<SpdySession> spdy_session =

+ base::WeakPtr<SpdySession> spdy_session =

CreateSecureSpdySession(session_, test_hosts[0].key, BoundNetLog());

EXPECT_TRUE(

« no previous file with comments | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/spdy/spdy_http_stream.h » ('j') | no next file with comments »