Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: net/http/http_stream_factory_impl_request.cc

Issue 18546008: [SPDY] Use WeakPtr<SpdySession> everywhere but SpdySessionPool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test, other minor formatting/comment changes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_request.h ('k') | net/http/http_stream_factory_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_request.cc
diff --git a/net/http/http_stream_factory_impl_request.cc b/net/http/http_stream_factory_impl_request.cc
index 9fb3931462b94392a9da63583507dbb3196a37af..e73a897a528b3516a604dc3637e358d773f7d4eb 100644
--- a/net/http/http_stream_factory_impl_request.cc
+++ b/net/http/http_stream_factory_impl_request.cc
@@ -279,7 +279,7 @@ HttpStreamFactoryImpl::Request::RemoveRequestFromHttpPipeliningRequestMap() {
void HttpStreamFactoryImpl::Request::OnNewSpdySessionReady(
Job* job,
- scoped_refptr<SpdySession> spdy_session,
+ const base::WeakPtr<SpdySession>& spdy_session,
bool direct) {
DCHECK(job);
DCHECK(job->using_spdy());
@@ -311,17 +311,17 @@ void HttpStreamFactoryImpl::Request::OnNewSpdySessionReady(
delegate_->OnWebSocketStreamReady(
job->server_ssl_config(),
job->proxy_info(),
- websocket_stream_factory_->CreateSpdyStream(spdy_session.get(),
+ websocket_stream_factory_->CreateSpdyStream(spdy_session,
use_relative_url));
} else {
bool use_relative_url = direct || url().SchemeIs("https");
delegate_->OnStreamReady(
job->server_ssl_config(),
job->proxy_info(),
- new SpdyHttpStream(spdy_session.get(), use_relative_url));
+ new SpdyHttpStream(spdy_session, use_relative_url));
}
// |this| may be deleted after this point.
- factory->OnNewSpdySessionReady(spdy_session.get(),
+ factory->OnNewSpdySessionReady(spdy_session,
direct,
used_ssl_config,
used_proxy_info,
« no previous file with comments | « net/http/http_stream_factory_impl_request.h ('k') | net/http/http_stream_factory_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698